Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks docs to use Spinx and Rst #316

Merged
merged 2 commits into from Oct 13, 2015
Merged

Reworks docs to use Spinx and Rst #316

merged 2 commits into from Oct 13, 2015

Conversation

phil-scott-78
Copy link
Contributor

Reworked the documentation to use Sphinx and reStructuredText markup
rather than mark down.

  • Added a contributing page on how to get this to build locally (you're
    gonna need python) as well as a style guideline
  • Converted the shouldBe and shouldNotBe documentation to reST
  • Added a simple example of bringing in source from an external file in
    the shouldBe documentation.

The example file pulls right from the unit test. I originally was going to
create a seperate project for just documentation purposes, but the
existing unit tests are so close that I didn't want to go down that route
without further input. Seems like some slight tweaking to the existing
unit tests on the formatting (and to throw in some Simpsons references)
and they could be used for the docs too.

Ultimately I think a "documentation" project will be needed. Little things
like referencing which line numbers to bring in would make working with
the unit test project and adjusting the using statements or adding a
comment could throw off the documentation.

Reworked the documentation to use Sphinx and reStructuredText markup
rather than mark down.

 * Added a contributing page on how to get this to build locally (you're
   gonna need python) as well as a style guideline
 * Converted the shouldBe and shouldNotBe documentation to reST
 * Added a simple example of bringing in source from an external file in
   the shouldBe documentation.

The example file pulls right from the unit test. I originally was going to
create a seperate project for just documentation purposes, but the
existing unit tests are so close that I didn't want to go down that route
without further input. Seems like some slight tweaking to the existing
unit tests on the formatting (and to throw in some Simpsons references)
and they could be used for the docs too.

Ultimately I think a "documentation" project will be needed. Little things
like referencing which line numbers to bring in would make working with
the unit test project and adjusting the using statements or adding a
comment could throw off the documentation.
@phil-scott-78 phil-scott-78 mentioned this pull request Oct 1, 2015
76 tasks
@phil-scott-78
Copy link
Contributor Author

Looks like this PR ha gotten behind. I was going to merge in the content added by @JoeMighty but before I go down that route I wanted to make sure that 1) no other content was in the queue to be merged and 2) this is still something to be considered for doing.

@JakeGinnivan
Copy link
Contributor

I am keen for it to go in, I have just been distracted on other things. @JoeMighty?

@josephwoodward
Copy link
Member

Me too! I'm looking forward to seeing this. If you want to update the PR with the changes I've added then I can merge the PR.

Merged TimeSpan documentation on ShouldNotBe.md into ShouldNotBe.rst and
removed the .md file
@phil-scott-78
Copy link
Contributor Author

Got the TimeSpan docs merged in and things look all set to be switched over. Not sure what has to be tweaked on the RTD side of things for it to see the change. I'm curious how that transition will go

JakeGinnivan added a commit that referenced this pull request Oct 13, 2015
Reworks docs to use Spinx and Rst
@JakeGinnivan JakeGinnivan merged commit d346047 into shouldly:master Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants