Add inline styleName to NavigationBar #104
Conversation
| '.inline': { | ||
| container: { | ||
| width: window.width, | ||
| position: 'relative', |
There was a problem hiding this comment.
Please fix indentation. Remove two extra spaces. Also, have you tested it how does it work in situations like this:
render() {
return (
<Screen>
<NavigationBar />
<ScrollView>
{/*Some scrollable content*/}
</ScrollView>
</Screen>
);
}I want to know would scroll view's content overlap navigation bar after scroll... If it would, then add zIndex to navigation bar's style.
Also, could you add this styleName to the documentation as well?
There was a problem hiding this comment.
Awesome! Sorry for the indentation =(
Yeah I tested on ListView.. going to take a look on ScrollView component.
There was a problem hiding this comment.
Hey, @guilhermedecampo did you find some time to test it? Are we good to go?
There was a problem hiding this comment.
Hey @guilhermedecampo can we merge it?
There was a problem hiding this comment.
Wow so sorry for all this time!
So I tested with both ListView and ScrollView components.
Check out the gifs below..
OBS: Take in consideration that I just changed NavigationBar and that there is a NavigationHeader this why the extra space on top.
Not working - not using inline styleName
Working - using inline styleName + ListView
Working - using inline styleName + ScrollView
|
And thank you for submitting the PR! |
|
@guilhermedecampo Thank you man! |
Fix NavigationBar being hidden by ListView.