Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for Github-style code blocks #9

Merged
merged 1 commit into from May 27, 2012

Conversation

Projects
None yet
8 participants
Contributor

rogerbraun commented Oct 20, 2011

This adds support for github-style code blocks like the ones found at http://github.github.com/github-flavored-markdown/.

+1

I'm now using this fork for Markdrop, and haven't run into any problems.

Contributor

rogerbraun commented Nov 4, 2011

Any chance of getting this merged? It's okay if it won't, but it would be good to know.

omarkhan commented Nov 7, 2011

+1

Contributor

rogerbraun commented Nov 25, 2011

I don't want to get pushy, but if there is no reaction I have to assume that this repo is not maintained any longer. That would not be a problem, but if this was the case I would maintain a fork myself.

+1

Looks good, though it doesn't seem to be stripping HTML characters like '<' to <, '>' to >, '&' to &, etc for html code examples like _DoCodeBlocks() does.

It should be like this:
<h1>Example</h1> = <code>&lt;h1&gt;Example&lt;/h1&gt;</code>

However it renders as:
<code><h1>Example</h1></code>

Fixed on my fork

@coreyti coreyti merged commit a589a98 into showdownjs:master May 27, 2012

Contributor

coreyti commented May 27, 2012

deepest apologies for the long delay. i was hoping to pull in a nice test suite, like those at https://github.com/chjj/marked and https://github.com/evilstreak/markdown-js, but can't find the time just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment