Spacebar should scroll in list mode #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received a report (RubenVerborgh/WebFundamentals#18) that the current spacebar behavior in Shower is non-intuitive. As you know, the space bar on webpages typically has the function of scrolling.
In slide mode, it makes sense to change this behavior, since scrolling does not apply there. This is what Shower currently does.
In list mode, however, scrolling seems to the preferred behavior. Yet Shower alters this behavior to skipping to the next slide (for which there are many other keybindings anyway). This commit fixes that behavior to scrolling in list mode.
Should you have any concerns please let me know. In particular:
case
fallthrough, which the style file allows me but you might not like.keys.js
test (is it full screen or not?), as the tests onmaster
currently don't run.