Pluginability of Shower #131

Open
azproduction opened this Issue Apr 1, 2013 · 17 comments

Comments

Projects
None yet
5 participants
@azproduction

A few days ago I wrote an Shower Remote. And I had some problems with Shower.

  • I want to know when shower calls next() or prev()
  • I want to know when shower enters full screen mode
  • I want to disable shower events in "Slave Mode" of Remote

Now I have to listen for bunch of events like keydown, click, touchstart, hashchange and do crazy stuff. And I am afraid of call shower methods directly.

It would be cool if shower had events.

shower.on('next', function () {});
shower.on('prev', function () {});
shower.on('slide', function (slideNo) {});
shower.on('mode', function (modeName) {});

And someone can trigger events instead of call shower methods to change shower state.

shower.trigger('next');
shower.trigger('prev');
shower.trigger('slide', 7);
shower.trigger('mode', 'fullscreen'); // true || shower.STATE_FULLSCREEN?
shower.trigger('disable', false); // do not handle DOM events

Shower Remote it is a good way to host a webinars. And with Shower events API Shower Remote will be much beter as Shower itself!

@azproduction

This comment has been minimized.

Show comment Hide comment
@azproduction

azproduction Apr 1, 2013

If the idea is approved, I can implement it in a couple of days.

If the idea is approved, I can implement it in a couple of days.

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey Apr 1, 2013

Owner

It makes a lot of sense not only for remotes, but for all possible Shower plugins.

@miripiruni, let's discuss it on Tuesday dinner.

Owner

pepelsbey commented Apr 1, 2013

It makes a lot of sense not only for remotes, but for all possible Shower plugins.

@miripiruni, let's discuss it on Tuesday dinner.

@azproduction

This comment has been minimized.

Show comment Hide comment
@azproduction

azproduction Apr 16, 2013

@pepelsbey have you decided?

@pepelsbey have you decided?

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey Apr 16, 2013

Owner

@miripiruni, ping-pong

Owner

pepelsbey commented Apr 16, 2013

@miripiruni, ping-pong

@miripiruni

This comment has been minimized.

Show comment Hide comment
@miripiruni

miripiruni Apr 16, 2013

Member

In my branch shower API have callbacks https://github.com/shower/shower/pull/123/files#L0L181
@azproduction you really need events?

Member

miripiruni commented Apr 16, 2013

In my branch shower API have callbacks https://github.com/shower/shower/pull/123/files#L0L181
@azproduction you really need events?

@azproduction

This comment has been minimized.

Show comment Hide comment
@azproduction

azproduction Apr 16, 2013

@miripiruni yes. And events is a good API interface. And by the way, all shower actions are pure events.

@miripiruni yes. And events is a good API interface. And by the way, all shower actions are pure events.

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey Apr 16, 2013

Owner

Guys, get a room already and discuss it ;) Or set up a Skype call and I'll join your conversation.

Owner

pepelsbey commented Apr 16, 2013

Guys, get a room already and discuss it ;) Or set up a Skype call and I'll join your conversation.

@miripiruni

This comment has been minimized.

Show comment Hide comment
@miripiruni

miripiruni Apr 17, 2013

Member

Skype? Ok! When?

Slava Oliyanchuk
http://miripiruni.org

On 17.04.2013, at 1:07, Vadim Makeev notifications@github.com wrote:

Guys, get a room already and discuss it ;) Or set up a Skype call and I'll join your conversation.


Reply to this email directly or view it on GitHub.

Member

miripiruni commented Apr 17, 2013

Skype? Ok! When?

Slava Oliyanchuk
http://miripiruni.org

On 17.04.2013, at 1:07, Vadim Makeev notifications@github.com wrote:

Guys, get a room already and discuss it ;) Or set up a Skype call and I'll join your conversation.


Reply to this email directly or view it on GitHub.

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey Apr 17, 2013

Owner

For me this Friday 17:00-19:00 (Moscow time) is the only option on this week.

Owner

pepelsbey commented Apr 17, 2013

For me this Friday 17:00-19:00 (Moscow time) is the only option on this week.

@miripiruni

This comment has been minimized.

Show comment Hide comment
@miripiruni

miripiruni Apr 17, 2013

Member
@azproduction

This comment has been minimized.

Show comment Hide comment
@azproduction

azproduction Apr 17, 2013

"this Friday 17:00-19:00 (Moscow time)" - OK. My Skype - a.z.production

"this Friday 17:00-19:00 (Moscow time)" - OK. My Skype - a.z.production

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey Apr 17, 2013

Owner

Decided: April 19th, 17:00 (Moscow) 30 minutes phone call on Shower API and pluginability.

Owner

pepelsbey commented Apr 17, 2013

Decided: April 19th, 17:00 (Moscow) 30 minutes phone call on Shower API and pluginability.

@Mavrin

This comment has been minimized.

Show comment Hide comment
@Mavrin

Mavrin May 2, 2014

what did guys decided?

Mavrin commented May 2, 2014

what did guys decided?

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey May 2, 2014

Owner

@Mavrin, guys decided to do this as soon as permanent JS developer will appear on this project.

Owner

pepelsbey commented May 2, 2014

@Mavrin, guys decided to do this as soon as permanent JS developer will appear on this project.

@Mavrin

This comment has been minimized.

Show comment Hide comment
@Mavrin

Mavrin May 2, 2014

When will it happen? Pluginability is important functionality. I can do that, but i don`t know which approach use "callback" or "event". I prefer "event" API.

Mavrin commented May 2, 2014

When will it happen? Pluginability is important functionality. I can do that, but i don`t know which approach use "callback" or "event". I prefer "event" API.

@pepelsbey

This comment has been minimized.

Show comment Hide comment
@pepelsbey

pepelsbey May 3, 2014

Owner

@Mavrin, let’s move discussion to email, please let me know what ideas do you have and I’ll explain nuances: pepelsbey@gmail.com.

Owner

pepelsbey commented May 3, 2014

@Mavrin, let’s move discussion to email, please let me know what ideas do you have and I’ll explain nuances: pepelsbey@gmail.com.

@gurugray

This comment has been minimized.

Show comment Hide comment
@gurugray

gurugray May 13, 2014

👍 for event API here

👍 for event API here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment