Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd crystal #2
Conversation
Goryudyuma
added some commits
Mar 9, 2018
This comment has been minimized.
This comment has been minimized.
|
実装はGolangをみながら、テンプレートはrubyのやつから改変しているので、少しいびつなところがあるかも知れません。 |
webapp/crystal/app.cr
Outdated
| Kemal::Session.config do |config| | ||
| config.cookie_name = "showwin_happy" | ||
| config.secret = "mysession" |
This comment has been minimized.
This comment has been minimized.
showwin
Mar 13, 2018
Owner
Goの実装が間違っていますが…
config.cookie_name = "mysession"
config.secret = ENV["ISHOCON1_SESSION_SECRET"] || "showwin_happy"
のつもりでした…！
参考: Ruby実装
webapp/crystal/app.cr
Outdated
| comment = env.params.body["content"]? || "" | ||
| c_user.create_comment(pid, comment) | ||
| env.redirect "/users/"+c_user.id.to_s |
This comment has been minimized.
This comment has been minimized.
webapp/crystal/app.cr
Outdated
| Kemal::Session.config do |config| | ||
| config.cookie_name = "mysession" | ||
| config.secret = "showwin_happy" |
This comment has been minimized.
This comment has been minimized.
showwin
Mar 13, 2018
Owner
コメント に書いたように環境変数を優先して頂けると
config.secret = ENV["ISHOCON1_SESSION_SECRET"] || "showwin_happy"
This comment has been minimized.
This comment has been minimized.
|
参考実装の言語追加ありがとうございます 動作確認はしていませんが、ざっとコード見て気になった部分だけコメントしました。(細かいところばかりですみません) |
Goryudyuma
added some commits
Mar 13, 2018
This comment has been minimized.
This comment has been minimized.
|
@showwin 直しました！ |
showwin
merged commit a511dcf
into
showwin:master
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Goryudyuma commentedMar 9, 2018
Crystal-langで書いてみました！
https://crystal-lang.org/
ベンチマークは通りましたが、言語差により細かい挙動はずれているかも知れません。