Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some tests; setup being able to mock httpclient in tests #9

Open
wants to merge 1 commit into
base: master
from

Conversation

@grantwinney
Copy link

grantwinney commented Oct 8, 2019

I didn't add a whole lot of tests, but if you like the direction of the PR, I could always add more before you merge it. I pulled in the mockhttp library from NuGet in order to mock out the HttpClient calls (making it possible to add more unit tests in the future).

I tried to keep all the changes in the test project. The only change to the pinboard.net project was to make PinboardAPI accept an HttpClient (with a null default parameter, so it shouldn't affect anyone currently using it), in order to inject the mocked client.

Let me know if you'd like anything changed in this. I used to have a pinboard account, but no more, so I don't have an auth token to verify my expectations are correct, but according to what I see in the api docs I'm fairly certain I got it right.

#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.