Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LogIn/Sign Up #5

Open
shreya024 opened this issue Aug 4, 2022 · 12 comments
Open

Implement LogIn/Sign Up #5

shreya024 opened this issue Aug 4, 2022 · 12 comments
Labels

Comments

@shreya024
Copy link
Owner

Implement the functionality of allowing users to login / sign up by choosing options from popular social media logins.

@shreya024 shreya024 added help wanted Extra attention is needed SSOC advanced labels Aug 4, 2022
@KARTIK-RAINA5802
Copy link

Heyy can i implement this functionality as i am familiar with node js, express and Oauth 2.0.

@souravbhunia07
Copy link

Heyy can I implement this functionality. please assign it to me.

@fykaa
Copy link
Collaborator

fykaa commented Aug 4, 2022

Hey @souravbhunia07 this issue is already assigned, we will be coming up with new issues, You can contribute to them. All the best 🎉

@KARTIK-RAINA5802
Copy link

Hey, do I need to create a frontend for Login/Sign Up also or just implementation, because there is no page for the login or sign up part and I could see someone is assigned to create a login page and which Social media login do we need for the user to sign in ?

@shreya024
Copy link
Owner Author

Hey, do I need to create a frontend for Login/Sign Up also or just implementation, because there is no page for the login or sign up part and I could see someone is assigned to create a login page and which Social media login do we need for the user to sign in ?

I have just merged the frontend for the login page. U can just work on implementation ,but feel free to make any minor changes required for the implementation

@KARTIK-RAINA5802
Copy link

Yess i just pulled the changes. Can you also merge the Sign Up page.

@shreya024
Copy link
Owner Author

Yess i just pulled the changes. Can you also merge the Sign Up page.

It is the Login/Sign Up page that I have merged.If you need major changes, let me know and I'll create another issue.Else you could implement using Conditional Rendering of text and minor changes as necessary

@shreya024
Copy link
Owner Author

@KARTIK-RAINA5802 Any updates?

@KARTIK-RAINA5802
Copy link

Yes actually this is my first time with React js and I was trying to get that sign-up page but ran into a lot of errors but finally solved that now and it's working fine.

Now I will start with the implementation part.

@KARTIK-RAINA5802
Copy link

Hey, I have implented the login/sign up functionality and also used passport.js to add authentication to make user credentials more secure and it's working fine.

May I make a PR ?

@shreya024
Copy link
Owner Author

Sure go ahead @KARTIK-RAINA5802

@KARTIK-RAINA5802
Copy link

hey, I tried to make a PR (actually 3) and it is able to pass two checks but fails on GitGuardian Security Checks. It's related to some mongoDB credentials so I removed the connection URL and commented secret part but it's still not happening. This is my first time making a PR and I don't know much about it. Can you help me with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants