Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn install #11

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Oct 20, 2017

The setup described in the readme (yarn install && yarn start) failed for me since package.json is missing a reference to react which is a peer-dependency of react-dom and react-router-dom.

Adding react-15.6.2 as a dependency makes the project install and start cleanly.

Fix yarn install
The setup described in the readme (`yarn install && yarn start`) failed
for me since package.json is missing a reference to react which is a
peer-dependency of react-dom and react-router-dom.

Adding react-15.6.2 as a dependency makes the project install and start
cleanly.

@shreyas-a shreyas-a merged commit f0be8a4 into shreyas-a:master Oct 21, 2017

@shreyas-a

This comment has been minimized.

Copy link
Owner

commented Oct 21, 2017

I'd like your inputs on the Webpack configuration in this repo. Or everything looks fine?

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Oct 21, 2017

Hi @shreyas-a; I'm not an expert in webpack so I can't comment much on the configuration. For simple applications like this one, I'd usually just rely on create-react-app which has very sensible defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.