Fix yarn install#11
Merged
shreyas-a merged 1 commit intoshreyas-a:masterfrom Oct 21, 2017
c-w:fix-yarn-install
Merged
Conversation
The setup described in the readme (`yarn install && yarn start`) failed for me since package.json is missing a reference to react which is a peer-dependency of react-dom and react-router-dom. Adding react-15.6.2 as a dependency makes the project install and start cleanly.
Owner
|
I'd like your inputs on the Webpack configuration in this repo. Or everything looks fine? |
Contributor
Author
|
Hi @shreyas-a; I'm not an expert in webpack so I can't comment much on the configuration. For simple applications like this one, I'd usually just rely on create-react-app which has very sensible defaults. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup described in the readme (
yarn install && yarn start) failed for me since package.json is missing a reference to react which is a peer-dependency of react-dom and react-router-dom.Adding react-15.6.2 as a dependency makes the project install and start cleanly.