Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce script time #3

Open
ernestomehra opened this issue Apr 24, 2020 · 1 comment
Open

Reduce script time #3

ernestomehra opened this issue Apr 24, 2020 · 1 comment

Comments

@ernestomehra
Copy link

You can actually remove those hard waits by simply implementing an explicit wait for the element visibility.

For eg: When you click on line 80, you can simply introduce the driver to check the loader element disappearing and then proceed. You don't necessary sleep for 1.5 seconds there.

@shri4r
Copy link
Owner

shri4r commented Apr 25, 2020

@ernestomehra

Thank you for your suggestion, much appreciated.

I will make those changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants