Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IO validation on upload_endpoint #446

Merged
merged 2 commits into from Feb 3, 2020
Merged

fix IO validation on upload_endpoint #446

merged 2 commits into from Feb 3, 2020

Conversation

@pldavid2
Copy link
Contributor

pldavid2 commented Jan 28, 2020

Fix IO validation on upload_endpoint as discussed here
https://discourse.shrinerb.com/t/upload-endpoint-with-authorization/121

Helps for example when someone wants to call Shrine.upload_response directly from a rails controller to add authentication.

@janko

This comment has been minimized.

Copy link
Member

janko commented Jan 28, 2020

The functionality looks good, thanks for the pull request! I will add tests and fix the formatting, and after that it should be ready to merge.

@janko janko merged commit 3301e9f into shrinerb:master Feb 3, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.