Hi Andrew and Aslak
I implemented a first version of descriptor readers. I tried not to change the existing descriptors. The changes are:
Let me know what you think.
Awesome to see some progress on this. Some comments:
This can fuel our discussions now set for:
I reformatted the ddJavaAll.xsd hoping that the this is now better.
Feedback sought to move forward: https://community.jboss.org/thread/198374
[SHRINKDESC-21] Added DescriptorReaders for all existing Descriptors
[SHRINKDESC-21] Working version of POC with test coverage
[SHRINKDESC-21] Implement deep-copy and ensure that toMutable() retur…
…ns a copy such that the immutable reference cannot be changed under the hood when passed to clients
[SHRINKDESC-21] Update after rebase w/ master
[SHRINKDESC-21] Synced with Andrews POC
I synced my stuff with yours. I will continue with the API enhancements because this will makes it easier. What I will do is:
Already done is to pass a 'class' as argument.
Cool, I see that this is rebased of upstream/SHRINKDESC-21.
With those addressed, we can likely squash your commits into one and
put it into upstream/SHRINKDESC-21.
Looking forward to making even more progress over this in person at
JUDCon and JBoss World!
Sorry that I was not precise enough. API changes must be agreed. I just want to discover possible solutions for problems reported by others. So, the existing API didn't change at all.
Question 1: These changes should allow that sequences of elements within a class can be passed in one call. When I mean sequences then I mean xsd:sequences which clearly says 'enter the following arguments in the this order'.
Question 2: The only other solution for up() is perhaps the standard new() operator. I think JAXB does it in the same way. Again, this is just an idea.
I will certainly not change the API without agreement and will also work on the read-only feature.
I hope this clarifies a little bit. And yes, I am looking forward as well to make progress at JUDCon and JBoss World.
[SHRINKDESC-21] Enhancements for a possible API change
I investigated some possible API enhancements which can be realized out of the generation step. The changes are just add-ons. The existing API is not changed at all. I will write a comment in the forum about this,
I will now investigate the read-only aspect further, so that we have a good base next week for a deeper discussion.
[SHRINKDESC-21] Synchronizing with Andrews POC
[SHRINKDESC-21] Synced with POC from Andrew
I synced your POC. I am not so happy because I realized that the idea I had introduces a new layer. The current state is:
I think, the state is good enough for the discussion.
See you tomorrow!