Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Sd 21 #57

Open
wants to merge 9 commits into from

3 participants

rbattenfeld Andrew Lee Rubinger Ralf Battenfeld
rbattenfeld

Hi Andrew and Aslak

I implemented a first version of descriptor readers. I tried not to change the existing descriptors. The changes are:

  1. The read-only descriptors are called DescriptorReader, e.g. WebAppDescriptorReader

  2. The descriptor readers are type safe as the mutual descriptors but I couldn't reuse the same types. I think this is ok. A user knows in advance which descriptors (mutual or read-only).

  3. I removed all service files. These files are now generated. This is possible because the metadata-parser allows also to specify the descriptor name.

  4. I wrote a small test case in the ejb-jar31 test folder to check the basics.

Let me know what you think.

Happy Easter
Ralf

Andrew Lee Rubinger
Owner
rbattenfeld

Hi Andrew,
I reformatted the ddJavaAll.xsd hoping that the this is now better.

Cheers,
Ralf

Andrew Lee Rubinger
Owner

Feedback sought to move forward: https://community.jboss.org/thread/198374

rbattenfeld

Hi Andrew

I synced my stuff with yours. I will continue with the API enhancements because this will makes it easier. What I will do is:

  • allow to define several arguments in one method like envEntry(name, type, value) in contrast to .name().type().value()
  • thinking to get rid of the not so popular up() method. So, the parent is hopefully not required anymore

Already done is to pass a 'class' as argument.

Regards,
Ralf

Andrew Lee Rubinger
Owner
rbattenfeld

Sorry that I was not precise enough. API changes must be agreed. I just want to discover possible solutions for problems reported by others. So, the existing API didn't change at all.

Question 1: These changes should allow that sequences of elements within a class can be passed in one call. When I mean sequences then I mean xsd:sequences which clearly says 'enter the following arguments in the this order'.

Question 2: The only other solution for up() is perhaps the standard new() operator. I think JAXB does it in the same way. Again, this is just an idea.

I will certainly not change the API without agreement and will also work on the read-only feature.

I hope this clarifies a little bit. And yes, I am looking forward as well to make progress at JUDCon and JBoss World.
Ralf

rbattenfeld

I investigated some possible API enhancements which can be realized out of the generation step. The changes are just add-ons. The existing API is not changed at all. I will write a comment in the forum about this,

I will now investigate the read-only aspect further, so that we have a good base next week for a deeper discussion.

Regards,
Ralf

rbattenfeld

Hi Andrew

I synced your POC. I am not so happy because I realized that the idea I had introduces a new layer. The current state is:

  1. The descriptors are based on your POC
  2. The filter element in your POC is replaced by the root element because this is the only valid element that can have a ref to the descriptor.
  3. The other elements are as before. I didn't had time to go further in my holidays:-)

I think, the state is good enough for the discussion.

See you tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 29, 2012
  1. Ralf Battenfeld Andrew Lee Rubinger
  2. Andrew Lee Rubinger
  3. Andrew Lee Rubinger

    [SHRINKDESC-21] Implement deep-copy and ensure that toMutable() retur…

    ALRubinger authored
    …ns a copy such that the immutable reference cannot be changed under the hood when passed to clients
  4. Andrew Lee Rubinger
Commits on Jun 15, 2012
  1. Ralf Battenfeld
  2. Ralf Battenfeld
Commits on Jun 18, 2012
  1. Ralf Battenfeld
Commits on Jun 21, 2012
  1. Ralf Battenfeld
Commits on Jun 23, 2012
  1. Ralf Battenfeld
Something went wrong with that request. Please try again.