Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Shrinkwrap 353 Shallow copy #44

Open
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

elefevre commented Nov 15, 2011

My implementation of shallow copy for archives.
I'm not entirely happy with the implementation (particularly, the fact that I have one implementation method per children class). Curious to hear if you have a better idea.

Owner

ALRubinger commented Nov 17, 2011

Agree with your concerns on this impl; what do you think of:

57980e2

...?

In this case we centralize the shallowCopy logic a bit (ie. no impl-per-child class) and also get to remove the static helper class. It also exposes a design flaw of ArchiveBase/MemoryMapArchiveImpl in that these are abusing the Archive contract to provide an underlying storage mechanism. For that I've opened SHRINKWRAP-362.

Let's sync up on upstream/SHRINKWRAP-353 until we're happy, then we'll push things into upstream/master. Looking forward to your comments on the approach I took here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment