Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rayon an optional dependency, because WASM #112

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@myfreeweb
Copy link
Contributor

myfreeweb commented Jul 5, 2018

On WebAssembly, Rayon does not work: the thread pool fails to initialize since threads are stubbed out.

With this and some changes to miniz_oxide (for now, described in Frommi/miniz_oxide#26), I've been able to run oxipng in the browser :)

wayland-screenshot-2018-07-05_16-33-27-fs8

Make Rayon an optional dependency
On WebAssembly, Rayon does not work (thread pool fails to initialize since threads are stubbed out).
@shssoichiro

This comment has been minimized.

Copy link
Owner

shssoichiro commented Jul 6, 2018

Thanks! Looks good, I'll go ahead and merge.

@shssoichiro shssoichiro merged commit ae65e4b into shssoichiro:master Jul 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.