Skip to content
This repository has been archived by the owner. It is now read-only.

Conflict between 'Make the vote buttons sticky' and 'Make the topbar fixed' #5

Closed
shu8 opened this issue Jul 8, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@shu8
Copy link
Owner

commented Jul 8, 2015

I'm using v1.4 and I noticed that the following features seem to clash somehow:

Make the topbar fixed (stay at the top as you scroll)
Make the vote buttons sticky
The topbar stays at the top, that works fine, but when scrolling, the upvote button disappears under the topbar. See the following screenshot for an example:

It would be great if the upvote button was visible all the time.

(from http://stackapps.com/a/6450/26088)

@shu8

This comment has been minimized.

Copy link
Owner Author

commented Jul 8, 2015

I could add margin-top: 34px; to the vote buttons but that has the effect of making the vote button start 34px down than the usual place and looks ugly...

Anyone know a better way to fix this? :)

@nwinkler

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Good question...

The issue seems to be that the sticky-element plugin uses a container to stick the vote buttons to, and the topbar position is simply set to fixed.

Maybe it's possible to play with the position of the topbar, changing the size of the page so that the container starts right below the topbar, instead of under the topbar.

@shu8

This comment has been minimized.

Copy link
Owner Author

commented Jul 9, 2015

@nwinkler Thanks for replying (my first reply on GitHub! :D)

This seems like a side-effect of fixing http://stackapps.com/a/6361/26088 - we ended up fixing the position and then pushing it back up - see the chat for details.

I'll need to look into the container and see whether I can make it start a bit lower down - depending on where it is, it might not cause the vote buttons to start 34px down from the top of the post (I hope!)

@shu8

This comment has been minimized.

Copy link
Owner Author

commented Aug 17, 2015

@nwinkler @Loxos fixed this! :)

@nwinkler

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Great! When will this be available in master? Any plans for your next official release?

@shu8

This comment has been minimized.

Copy link
Owner Author

commented Aug 30, 2015

I'm away at the moment but I think I'll update it to master in the second
week of September! :)

On Thursday, 27 August 2015, Nils Winkler notifications@github.com wrote:

Great! When will this be available in master? Any plans for your next
official release?


Reply to this email directly or view it on GitHub
#5 (comment)
.

Sent from Gmail Mobile

@nwinkler

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

Great, thanks for the update!

@shu8 shu8 referenced this issue Sep 8, 2015

Merged

v1.6 merge #17

shu8 added a commit that referenced this issue Sep 8, 2015

v1.6 merge
#16 #5 #10 fixed.

Thanks #14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.