From 20db42b881b0302bd413e46d49eaba71d6779d87 Mon Sep 17 00:00:00 2001 From: Tim Neutkens Date: Sat, 22 Oct 2022 14:26:57 +0200 Subject: [PATCH] Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import trace (#41645) --- .../parseNotFoundError.ts | 2 +- .../acceptance-app/ReactRefresh.test.ts | 4 ++ .../ReactRefreshLogBox-builtins.test.ts | 8 ++- .../ReactRefreshLogBox-scss.test.ts | 2 + .../acceptance-app/ReactRefreshLogBox.test.ts | 4 ++ .../ReactRefreshLogBoxMisc.test.ts | 4 ++ .../acceptance-app/ReactRefreshModule.test.ts | 4 ++ .../ReactRefreshRegression.test.ts | 2 + .../ReactRefreshRequire.test.ts | 4 ++ .../ReactRefreshLogBox-builtins.test.ts.snap | 52 +++++++++++++++++++ 10 files changed, 83 insertions(+), 3 deletions(-) create mode 100644 test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap diff --git a/packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts b/packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts index a33478e7d5de5..ee0c0627c1fc9 100644 --- a/packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts +++ b/packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts @@ -85,7 +85,7 @@ export async function getNotFoundError( .filter( (name) => name && - !/next-(middleware|client-pages|flight-(client|server))-loader\.js/.test( + !/next-(middleware|client-pages|flight-(client|server|client-entry))-loader\.js/.test( name ) ) diff --git a/test/development/acceptance-app/ReactRefresh.test.ts b/test/development/acceptance-app/ReactRefresh.test.ts index 6e5c0d961cdab..d7c18b6ab26c8 100644 --- a/test/development/acceptance-app/ReactRefresh.test.ts +++ b/test/development/acceptance-app/ReactRefresh.test.ts @@ -15,6 +15,10 @@ describe('ReactRefresh app', () => { beforeAll(async () => { next = await createNext({ files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), + dependencies: { + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', + }, skipStart: true, }) }) diff --git a/test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts b/test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts index ee9eed93dc652..ff5bbf08c690f 100644 --- a/test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts +++ b/test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts @@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base' import path from 'path' // TODO-APP: Investigate snapshot mismatch -describe.skip('ReactRefreshLogBox app', () => { +describe('ReactRefreshLogBox app', () => { if (process.env.NEXT_TEST_REACT_VERSION === '^17') { it('should skip for react v17', () => {}) return @@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => { beforeAll(async () => { next = await createNext({ files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), + dependencies: { + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', + }, skipStart: true, }) }) @@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => { await cleanup() }) - test('Module not found (missing global CSS)', async () => { + test('Module not found missing global CSS', async () => { const { session, cleanup } = await sandbox( next, new Map([ diff --git a/test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts b/test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts index e6125bd74b75c..a15abd4ee8805 100644 --- a/test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts +++ b/test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts @@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => { skipStart: true, dependencies: { sass: 'latest', + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', }, }) }) diff --git a/test/development/acceptance-app/ReactRefreshLogBox.test.ts b/test/development/acceptance-app/ReactRefreshLogBox.test.ts index 7dbda9fd70905..c468e2f5336b1 100644 --- a/test/development/acceptance-app/ReactRefreshLogBox.test.ts +++ b/test/development/acceptance-app/ReactRefreshLogBox.test.ts @@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => { beforeAll(async () => { next = await createNext({ files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), + dependencies: { + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', + }, skipStart: true, }) }) diff --git a/test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts b/test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts index 48822651cab52..df22c53aab9cd 100644 --- a/test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts +++ b/test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts @@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => { beforeAll(async () => { next = await createNext({ files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), + dependencies: { + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', + }, skipStart: true, }) }) diff --git a/test/development/acceptance-app/ReactRefreshModule.test.ts b/test/development/acceptance-app/ReactRefreshModule.test.ts index ec76bf6b81787..ac90537a3e0a5 100644 --- a/test/development/acceptance-app/ReactRefreshModule.test.ts +++ b/test/development/acceptance-app/ReactRefreshModule.test.ts @@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => { beforeAll(async () => { next = await createNext({ files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), + dependencies: { + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', + }, skipStart: true, }) }) diff --git a/test/development/acceptance-app/ReactRefreshRegression.test.ts b/test/development/acceptance-app/ReactRefreshRegression.test.ts index 3cb39a3a942d2..6f4c584b5c1b6 100644 --- a/test/development/acceptance-app/ReactRefreshRegression.test.ts +++ b/test/development/acceptance-app/ReactRefreshRegression.test.ts @@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => { 'styled-components': '5.1.0', '@next/mdx': 'canary', '@mdx-js/loader': '0.18.0', + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', }, }) }) diff --git a/test/development/acceptance-app/ReactRefreshRequire.test.ts b/test/development/acceptance-app/ReactRefreshRequire.test.ts index 7bbf3bf8ca1a1..28078e7ec561a 100644 --- a/test/development/acceptance-app/ReactRefreshRequire.test.ts +++ b/test/development/acceptance-app/ReactRefreshRequire.test.ts @@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => { beforeAll(async () => { next = await createNext({ files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), + dependencies: { + react: '0.0.0-experimental-9cdf8a99e-20221018', + 'react-dom': '0.0.0-experimental-9cdf8a99e-20221018', + }, skipStart: true, }) }) diff --git a/test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap b/test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap new file mode 100644 index 0000000000000..fc2a1bc5c1e4c --- /dev/null +++ b/test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap @@ -0,0 +1,52 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`ReactRefreshLogBox app Module not found 1`] = ` +"./index.js:1:0 +Module not found: Can't resolve 'b' +> 1 | import Comp from 'b' + 2 | export default function Oops() { + 3 | return ( + 4 |
+ +Import trace for requested module: +./app/page.js + +https://nextjs.org/docs/messages/module-not-found" +`; + +exports[`ReactRefreshLogBox app Module not found empty import trace 1`] = ` +"./app/page.js:2:6 +Module not found: Can't resolve 'b' + 1 | 'use client' +> 2 | import Comp from 'b' + | ^ + 3 | export default function Oops() { + 4 | return ( + 5 |
+ +https://nextjs.org/docs/messages/module-not-found" +`; + +exports[`ReactRefreshLogBox app Module not found missing global CSS 1`] = ` +"./app/page.js:2:10 +Module not found: Can't resolve './non-existent.css' + 1 | 'use client' +> 2 | import './non-existent.css' + | ^ + 3 | export default function Page(props) { + 4 | return

index page

+ 5 | } + +https://nextjs.org/docs/messages/module-not-found" +`; + +exports[`ReactRefreshLogBox app Node.js builtins 1`] = ` +"./node_modules/my-package/index.js:2:0 +Module not found: Can't resolve 'dns' + +Import trace for requested module: +./index.js +./app/page.js + +https://nextjs.org/docs/messages/module-not-found" +`;