Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot change directory to c:\ by .. #15

Open
gotoh opened this issue Jul 17, 2024 · 0 comments
Open

cannot change directory to c:\ by .. #15

gotoh opened this issue Jul 17, 2024 · 0 comments

Comments

@gotoh
Copy link
Contributor

gotoh commented Jul 17, 2024

Current code has an unexpected behaviour:

c:\ $ cd c:\temp\foo
c:\temp\foo $ z ...
c:\temp $ z ..
zoxide: no match found
c:\temp $
gotoh added a commit to gotoh/clink-zoxide that referenced this issue Jul 17, 2024
@gotoh
give unquoted full path string to os.isdir() (resolve shunsambongi#11 …
9eef9bf 
…and shunsambongi#15)

`os.isdir("..")` on `c:\temp` unexpectedly returns nil.
This can be avoided by calling `os.isdir()` with the full path. This solves issue shunsambongi#15
Additionally, `os.getfullpathname()` expects its argument to be unquoted,
so we must pass the unquoted value. This change also resolves issue shunsambongi#11.
.
@gotoh gotoh mentioned this issue Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gotoh