Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Port to new Vecty API #84
This change ports Go-Package-Store over to the new Vecty API, which recently had a breaking change.
Relies on PR gopherjs/vecty#138 being merged first, which fixes a Vecty regression observed here.
No visual / functional changes are made, this just switches over to the new API. I ran out of time while writing this PR to properly make the commits very small / logical and reference exact README links. It's still best reviewed as individual commits, but the last commit in specific is not perfectly split apart into logical pieces. I won't have time to update this PR for probably a few more weeks, so if helpful please feel free to take / modify my changes here as you see fit :) I'll do my best to answer any questions here as I have time.
I know :) I wanted to! And I was curious how hard the upgrade path would be, and what unexpected things may be encountered. I was happy to do this because it ended up leading me to that regression we accidently introduced in Vecty (the PR mentioned in the description that is now merged).
@slimsag I believe I'm seeing a regression in rendering behavior. Look at these two frames, in sequence:
The frame above looks good. In the next frame, the only change that should happen is that "Checking for updates..." text should disappear. But in addition to that happening, the displayed packages become incorrect. The 4th package disappears, the first one becomes duplicated.
Tested using the version of Vecty roughly after gopherjs/vecty#138 was merged, and using latest version. Same result.
Ok, it is a regression, but not with the new API. It happened before.
I did some archeology. I merged the Vecty branch and regenerated on April 13. I was using the latest Vecty commit at the time, which would be gopherjs/vecty@a32ca06.
I checked out that commit locally and tested it out, the issue does not occur:
I'll try to bisect to where it happened exactly. Edit: Done git bisect, reported results in gopherjs/vecty#149.
In any case, that's a separate issue from the API change, so I won't let it stop me from merging this PR.
referenced this pull request
Sep 19, 2017
@slimsag I've pushed a 4th commit to this PR. It kinda reverts the code layout changes you've applied, but updates to use the new API.
Basically, my goal with this PR is to make minimal change to update to new API. I will consider code organization and style changes in followup changes - I don't want that to be a part of this one.
So, what I ended up doing is effectively replacing my previous use of