New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing edge cases in queryArguments. #7

Merged
merged 3 commits into from Dec 1, 2017

Conversation

1 participant
@dmitshur
Member

dmitshur commented Nov 30, 2017

Previously, queryArguments was partially implemented to handle the most common types I had run into, with a TODO to complete the rest.

This change implements the support for the remaining argument types. Now, slices of T are mapped to "[T]!", and pointers to slices of T are mapped to "[T]", as per GraphQL specification.

Add a comment pointing out that commas are omitted because they're insignificant (see https://facebook.github.io/graphql/October2016/#sec-Insignificant-Commas), and we're looking to produce minified output (less bytes to send over the network).

Fixes #6.

Implement missing edge cases in queryArguments.
Previously, queryArguments was partially implemented to handle the most
common types I had run into, with a TODO to complete the rest.

This change implements the support for the remaining argument types.
Now, slices of T are mapped to "[T]!", and pointers to slices of T are
mapped to "[T]", as per GraphQL specification.

Add a comment pointing out that commas are omitted because they're
insignificant, and we're looking to produce minified output (less bytes
to send over the network).

Fixes #6.

dmitshur added some commits Nov 30, 2017

Improve internal comments.
Use simpler examples.

@dmitshur dmitshur merged commit d0549ed into master Dec 1, 2017

4 checks passed

ci/gopherci/pr Found no issues \ʕ◔ϖ◔ʔ/
Details
ci/gopherci/push Found no issues \ʕ◔ϖ◔ʔ/
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dmitshur dmitshur deleted the improve-queryArguments branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment