Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vfsutil compatibility issue with statik/fs #9

Conversation

Projects
None yet
2 participants
@shakahl
Copy link

commented May 26, 2019

No description provided.

@shakahl shakahl changed the title #1 - Fixed vfsutil compatibility issue with statik/fs Fixed vfsutil compatibility issue with statik/fs May 26, 2019

rakyll added a commit to rakyll/statik that referenced this pull request Jul 9, 2019

fs: handle Readdir(0) same as Readdir(< 0) (#69)
Implementations of the File.Readdir method are expected to treat
all n <= 0 values the same, returning all the os.FileInfo structures
from the directory in a single slice. This is documented at
https://godoc.org/net/http#File.Readdir and https://godoc.org/os#File.Readdir.

Previously, the n == 0 value was not being handled correctly.
This change fixes it by making it work the same as all other
negative values of n.

Add a test case for it.

Also simplify string(out.Bytes()) to just out.String() in a test.

Fixes #68.
Fixes shurcooL/httpfs#8.
Closes shurcooL/httpfs#9.
@dmitshur

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Resolved via rakyll/statik#69.

@dmitshur dmitshur closed this Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.