Permalink
Browse files

githubapi: Increase page size to maximum allowed.

This improves efficiency by making fewer requests to get all comments.

The page size was intentionally set to an extremely low value of 1
during development, to verify that pagination was working correctly.
  • Loading branch information...
dmitshur committed Nov 11, 2017
1 parent e604514 commit aa4ff8c7f44a417f95954447fadbb0c4b5cfde6b
Showing with 1 addition and 1 deletion.
  1. +1 −1 githubapi/githubapi.go
View
@@ -280,7 +280,7 @@ func (s service) ListComments(ctx context.Context, rs issues.RepoSpec, id uint64
EndCursor githubql.String
HasNextPage githubql.Boolean
}
} `graphql:"comments(first:1,after:$commentsCursor)"` // TODO: Increase page size too 100 after done testing.
} `graphql:"comments(first:100,after:$commentsCursor)"`
} `graphql:"issue(number:$issueNumber)"`
} `graphql:"repository(owner:$repositoryOwner,name:$repositoryName)"`
}

0 comments on commit aa4ff8c

Please sign in to comment.