New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

### type headers #37

Closed
anacrolix opened this Issue Oct 9, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@anacrolix

anacrolix commented Oct 9, 2017

I assume the tool is intentionally quite opinionated. It doesn't handle headers that were indented ### and beyond. I'd love to know your reasoning for preferring the style it instead uses.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 11, 2017

Member

I assume the tool is intentionally quite opinionated.

It is.

It doesn't handle headers that were indented ### and beyond.

It should. Can you elaborate? What input, what did you expect to get, what did you get instead?

Member

dmitshur commented Oct 11, 2017

I assume the tool is intentionally quite opinionated.

It is.

It doesn't handle headers that were indented ### and beyond.

It should. Can you elaborate? What input, what did you expect to get, what did you get instead?

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 11, 2017

Member

In fact, see this line in the test file:

### An h3 header

Member

dmitshur commented Oct 11, 2017

In fact, see this line in the test file:

### An h3 header

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 11, 2017

Member

Perhaps the problem is that you didn't have a space after the hashes, ala ###attempted header? The space is strictly required.

Member

dmitshur commented Oct 11, 2017

Perhaps the problem is that you didn't have a space after the hashes, ala ###attempted header? The space is strictly required.

@anacrolix

This comment has been minimized.

Show comment
Hide comment
@anacrolix

anacrolix Oct 11, 2017

I expected it to leave all the # style headers alone, or also rewrite my ### headers into the ---- and ==== underlined style it uses. It appears that it leaves h3 and further alone?

anacrolix commented Oct 11, 2017

I expected it to leave all the # style headers alone, or also rewrite my ### headers into the ---- and ==== underlined style it uses. It appears that it leaves h3 and further alone?

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 11, 2017

Member

It's because the underlined styles exist for h1 and h2 only, so h3 has no choice but to use ### style. See https://daringfireball.net/projects/markdown/syntax#header.

Member

dmitshur commented Oct 11, 2017

It's because the underlined styles exist for h1 and h2 only, so h3 has no choice but to use ### style. See https://daringfireball.net/projects/markdown/syntax#header.

@anacrolix

This comment has been minimized.

Show comment
Hide comment
@anacrolix

anacrolix commented Oct 11, 2017

Ok thanks

@anacrolix anacrolix closed this Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment