New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failure on latest git head: Difference of 58 lines #44

Closed
eclipseo opened this Issue Oct 26, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@eclipseo
Copy link

eclipseo commented Oct 26, 2018

Testing: "/builddir/build/BUILD/markdownfmt-5ba28a0bf0048ea9b00cecd23688dcf6cfb23fe5/_build/src/github.com/shurcooL/markdownfmt/markdown"
+ GOPATH=/builddir/build/BUILD/markdownfmt-5ba28a0bf0048ea9b00cecd23688dcf6cfb23fe5/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
--- FAIL: Test (0.00s)
    main_test.go:291: Difference of 58 lines:
        --- /tmp/markdownfmt295757931	2018-10-26 12:51:22.733756205 +0000
        +++ /tmp/markdownfmt037567182	2018-10-26 12:51:22.733756205 +0000
        @@ -152,27 +152,27 @@
         	    break;
         	```
         
        -### Blockquote within list
        +	### Blockquote within list
         
        --	list1
        +	-	list1
         
         	> This a quote within a list.
         
        -### Table within list
        +	### Table within list
         
        --	list1
        +	-	list1
         
         	| Header One | Header Two |
         	|------------|------------|
         	| Item One   | Item Two   |
         
        -### Multi-level nested
        +	### Multi-level nested
         
        --	Item 1
        +	-	Item 1
         
         	Another paragraph inside this list item is indented just like the previous paragraph.
         
        --	Item 2
        +	-	Item 2
         
         	-	Item 2a
         
        @@ -184,13 +184,13 @@
         
         	-	Item 2b
         
        --	Item 3
        +	-	Item 3
         
        -Line Breaks
        -===========
        +	Line Breaks
        +	===========
         
        -Some text with two trailing spaces for linebreak.  
        -More text immediately after.  
        -Useful for writing poems.
        +	Some text with two trailing spaces for linebreak.  
        +	More text immediately after.  
        +	Useful for writing poems.
         
        -Done.
        +	Done.
FAIL
exit status 1
FAIL	github.com/shurcooL/markdownfmt/markdown	0.012s
@eclipseo

This comment has been minimized.

Copy link
Author

eclipseo commented Oct 26, 2018

The only noticeable change I made from my previous build is using Blackfriday v1.5.2.

Might be related to the changes made in russross/blackfriday#239

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Oct 26, 2018

This is due to a regression in russross/blackfriday#476. The tracking bug for it is russross/blackfriday#495.

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 26, 2019

The upstream issue russross/blackfriday#495 is fixed (thanks @aignas!), and markdownfmt tests are passing too now. Closing.

@dmitshur dmitshur closed this Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment