Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor testcases #45
Refactor the test cases into input/output files to make it simpler to add
Test cases can now be defined by creating a file inside
Additionally adds new flag to the test cases called "-update_goldens"
PS: it was a joy to update the tests after the blackfriday update
1 similar comment
Hi @achew22, thanks for the pings, they are helpful.
This is on my radar, but I have some more pressing and time-sensitive work to complete first. I hope I'll be able to get to this next weekend or so.
Sorry about the delay in getting to this, I haven't had many resources available for open source maintenance lately.
dmitshur left a comment
I'm going to merge this but with modifications. I'd like to simplify this as much as viable, and make it more consistent with my other code.
One of the design goals of
I'm also not going to keep the README inside
Thank you for working on this, and sorry again it took so long to get around to reviewing it.
I should do a better job of communicating the status of this package in the README, but for reference, I am more eager to freeze it rather than develop it further. If you're interested in changing behavior or adding features, it's better to do so on a fork.