Permalink
Browse files

Rename shurcool variables to dmitshur.

This is consistent with my current preferred username, already used
on GitHub, Twitter, and elsewhere.

Reference: https://twitter.com/dmitshur/status/1021266582834634752.
  • Loading branch information...
dmitshur committed Oct 7, 2018
1 parent abdf68e commit 33b7b5e8c05d3b390ab4e6c9e9fc7703740dd584
Showing with 6 additions and 6 deletions.
  1. +4 −4 resume.go
  2. +2 −2 resume_test.go
View
@@ -12,10 +12,10 @@ import (
)
// DmitriShuralyov returns Dmitri Shuralyov's resume,
// using the basic user information of shurcool,
// using the basic user information of dmitshur,
// and the current local time now.
// It's annotated with the given reactions from the perspective of currentUser.
func DmitriShuralyov(shurcool users.User, now time.Time, reactions map[string][]reactions.Reaction, currentUser users.User) htmlg.Component {
func DmitriShuralyov(dmitshur users.User, now time.Time, reactions map[string][]reactions.Reaction, currentUser users.User) htmlg.Component {
// reactable is a convenience helper that joins reactable content with its ReactionsBar,
// using id as reactable ID. It populates ReactionsBar's Reactions and CurrentUser fields.
reactable := func(id string, content htmlg.Component) htmlg.Component {
@@ -29,12 +29,12 @@ func DmitriShuralyov(shurcool users.User, now time.Time, reactions map[string][]
resume := component.Join(
resumecomponent.Name{
Name: shurcool.Name,
Name: dmitshur.Name,
},
resumecomponent.ContactInfo{
GitHub: component.Link{Text: "github.com/dmitshur", URL: "https://github.com/dmitshur", NewTab: true},
Email: component.Link{Text: shurcool.Email, URL: "mailto:" + shurcool.Email, NewTab: true},
Email: component.Link{Text: dmitshur.Email, URL: "mailto:" + dmitshur.Email, NewTab: true},
},
resumecomponent.Section{
View
@@ -19,7 +19,7 @@ var updateFlag = flag.Bool("update", false, "Update golden files.")
// TestDmitriShuralyov validates that rendering resume.DmitriShuralyov produces expected HTML.
func TestDmitriShuralyov(t *testing.T) {
var (
shurcool = users.User{
dmitshur = users.User{
UserSpec: users.UserSpec{ID: 1924134, Domain: "github.com"},
Name: "Dmitri Shuralyov",
Email: "dmitri@shuralyov.com",
@@ -42,7 +42,7 @@ func TestDmitriShuralyov(t *testing.T) {
)
var buf bytes.Buffer
err := htmlg.RenderComponents(&buf, resume.DmitriShuralyov(shurcool, mockTime, mockReactions, alice))
err := htmlg.RenderComponents(&buf, resume.DmitriShuralyov(dmitshur, mockTime, mockReactions, alice))
if err != nil {
t.Fatal(err)
}

0 comments on commit 33b7b5e

Please sign in to comment.