New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation fix for beginner-friendliness #51

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tariq1890

tariq1890 commented Sep 11, 2018

No description provided.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Sep 11, 2018

Member

Thanks for the PR!

I'm a bit worried that the very next paragraph talks about assets, but it's a different one. It's the assets variable in the generated .go file, not the input filesystem fs.

What are your thoughts on that?

Member

dmitshur commented Sep 11, 2018

Thanks for the PR!

I'm a bit worried that the very next paragraph talks about assets, but it's a different one. It's the assets variable in the generated .go file, not the input filesystem fs.

What are your thoughts on that?

@tariq1890

This comment has been minimized.

Show comment
Hide comment
@tariq1890

tariq1890 Sep 11, 2018

I understand. My PR just fixes the small inconsistency. Personally, I found it confusing when I was trying to learn vfsgen. Perhaps a different name altogether for that snippet alone?

tariq1890 commented Sep 11, 2018

I understand. My PR just fixes the small inconsistency. Personally, I found it confusing when I was trying to learn vfsgen. Perhaps a different name altogether for that snippet alone?

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Sep 15, 2018

Member

@tariq1890 I tried to elaborate and clarify the Usage section in PR #53. Can you let me know if you think it's helpful?

Member

dmitshur commented Sep 15, 2018

@tariq1890 I tried to elaborate and clarify the Usage section in PR #53. Can you let me know if you think it's helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment