Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

changed comment

  • Loading branch information...
commit cb4dba61dcca17361e96a4b1ea0f9f7f9b415ea7 1 parent be7605a
@kajboj kajboj authored
Showing with 3 additions and 4 deletions.
  1. +3 −4 lib/shutl/resource/errors.rb
View
7 lib/shutl/resource/errors.rb
@@ -9,10 +9,9 @@ def initialize message, http_response
end
# This NoQuotesGenerated is shutl specific corresponding to HTTP status 299.
-# We had a good think about what the correct HTTP code is for the case that
-# the request is fine, but we couldn't generate any quotes. It doesn't feel
-# like a 4xx or a 5xx, but not quite like a 2xx either. Comments/thoughts
-# more than welcome.
+# The correct solution to this would be to remove this exception from the gem
+# and handle specifically in a QuoteCollection resource in for example the
+# 'shutl' gem.
Shutl::NoQuotesGenerated = Class.new Shutl::Resource::Error
Shutl::BadRequest = Class.new Shutl::Resource::Error
Please sign in to comment.
Something went wrong with that request. Please try again.