New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct package name in the installation docs #2

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@JackWH
Copy link
Contributor

JackWH commented Mar 9, 2017

The installation docs referenced composer require shutterstock/php-shutterstock-api, but this is not a valid package name.

Rewording to composer require shutterstock/api fixes the issue, as this is the name given in the composer.json file.

Used the correct package name in the installation docs
The installation docs referenced `composer require shutterstock/php-shutterstock-api`, but this is not a valid package name.

Rewording to `composer require shutterstock/api` fixes the issue, as this is the name given in the `composer.json` file.
@peter279k

This comment has been minimized.

Copy link

peter279k commented May 17, 2018

This PR should be merged and it's related about this issue #1 .

@behradkhodayar

This comment has been minimized.

Copy link

behradkhodayar commented Sep 25, 2018

The tests are also passed?! So whats wrong with merging it? If you got no time there, no matter, give some privileges to me & I'll keep it updated.

@peter279k

This comment has been minimized.

Copy link

peter279k commented Sep 25, 2018

@behradkhodayar, thank you for your reply. This is about the package name.
And I think this doesn't have any test to be passed.

@behradkhodayar

This comment has been minimized.

Copy link

behradkhodayar commented Sep 25, 2018

@peter279k exactly! Hope it gets reflected soon

@jacobemerick

This comment has been minimized.

Copy link
Contributor

jacobemerick commented Sep 28, 2018

👍

@jacobemerick

This comment has been minimized.

Copy link
Contributor

jacobemerick commented Sep 28, 2018

Thanks @JackWH

@jacobemerick jacobemerick merged commit 553b8e1 into shutterstock:master Sep 28, 2018

@jacobemerick jacobemerick referenced this pull request Sep 28, 2018

Closed

Invalid package name #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment