Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed Travis CI build #6

Merged

Conversation

@peter279k
Copy link
Contributor

commented Sep 11, 2019

Changed log

  • To fix failed Travis CI build, it should use vendor/bin/phpunit version because the default PHPUnit build version is not correct for php-7.x versions.
  • To be compatible with multiple php-7.x versions, it should define multiple PHPUnit versions for different PHP versions.
  • To support latest stable PHPUnit version, using the PHPUnit\Framework\TestCase namespace.

@jacobemerick, please look at this PR, thanks.

@peter279k peter279k force-pushed the open-source-contributions:fix_travis branch from 1527d87 to b502651 Sep 11, 2019
@peter279k peter279k force-pushed the open-source-contributions:fix_travis branch from b502651 to 5932683 Sep 11, 2019
@peter279k

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

The Travis CI build log is available here.

Just notice that the Code Climate service is failed because the code climate id is not available on forked repository.

Copy link
Contributor

left a comment

Thank you!

@jacobemerick jacobemerick merged commit 54a50c9 into shutterstock:master Sep 20, 2019
@peter279k peter279k deleted the open-source-contributions:fix_travis branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.