Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds npm deploy on tag #5

Merged
merged 2 commits into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@jacobemerick
Copy link
Collaborator

jacobemerick commented Mar 29, 2019

No description provided.

@jacobemerick jacobemerick requested a review from msmol Mar 29, 2019

@jacobemerick jacobemerick force-pushed the npm-deploy branch from aa34f09 to ddfc43d Mar 29, 2019

@jacobemerick jacobemerick force-pushed the npm-deploy branch from ddfc43d to c948e16 Mar 29, 2019

@msmol

msmol approved these changes Mar 29, 2019

@msmol

This comment has been minimized.

Copy link
Collaborator

msmol commented Mar 29, 2019

what is the npm package name that this deploys to? is that built into the $SSTK_NPM_TOKEN ?

@@ -1,5 +1,5 @@
{
"name": "shutterstock",
"name": "shutterstock-api",

This comment has been minimized.

Copy link
@msmol

msmol Mar 29, 2019

Collaborator

how does this affect the generated code?

This comment has been minimized.

Copy link
@jacobemerick

jacobemerick Apr 1, 2019

Author Collaborator

This should not impact the generated code, especially because our generator assumes shutterstock-api already. https://github.com/shutterstock/public-api-sdk-generator/blob/master/build/sdk/js/templates/package.mustache#L2

This comment has been minimized.

Copy link
@msmol

msmol Apr 1, 2019

Collaborator

I believe it affects the generated documentation however. @timothymcmackin, thoughts?

This comment has been minimized.

Copy link
@timothymcmackin

timothymcmackin Apr 1, 2019

Member

Not quite sure how this pipeline works. Shouldn't the package.json get generated from the mustache templates in public-api-sdk-generator and overwrite this one?

@timothymcmackin timothymcmackin self-requested a review Apr 1, 2019

@jacobemerick jacobemerick merged commit 2598ac1 into master Apr 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.