Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK Build #128

Merged
merged 3 commits into from Nov 4, 2019

Conversation

@jacobemerick
Copy link
Contributor

jacobemerick commented Nov 1, 2019

No description provided.

@jacobemerick jacobemerick requested review from msmol and shwetasabne Nov 1, 2019
Dockerfile Outdated
@@ -24,6 +24,6 @@ COPY --from=swagger-build /opt/swagger-build/swagger2.json .
COPY build/sdk/js/templates ./build/sdk/js/templates
COPY build/sdk/config.json .

RUN java -jar /opt/swagger-codegen-cli/swagger-codegen-cli.jar generate -i ./swagger2.json -o ./dist -c ./config.json -l javascript -t ./build/sdk/js/templates

This comment has been minimized.

Copy link
@msmol

msmol Nov 1, 2019

Collaborator

why doesn't outputting to ./dist work?

This comment has been minimized.

Copy link
@jacobemerick

jacobemerick Nov 1, 2019

Author Contributor

Locally it was ending up in /dist/dist sometimes.

This comment has been minimized.

Copy link
@jacobemerick

jacobemerick Nov 1, 2019

Author Contributor

Re-running locally, this seems weird to me now too.

@msmol
msmol approved these changes Nov 1, 2019
@jacobemerick jacobemerick merged commit 7799139 into master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jacobemerick jacobemerick deleted the fix-sdk-build branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.