Skip to content

max property set to zero is ignored #178

Closed
kvermilion opened this Issue Jan 9, 2013 · 1 comment

2 participants

@kvermilion

zero is interperated as undefined ("auto")

The offending lines in 1.1.2 are:

In Rickshaw.Graph.js
var yMax = this.graph.max || d3.max( values )

In Rickshaw.Graph.Renderer.js
var yMax = this.graph.max || d3.max( values )

Basically:
0 || undefined -> undefined, so any 0 arg gets set to undefined, in the first line noted.
then undefined || anything -> anything. so you always end up witjh d3.max( values ) if you set max to zero

@dchester

Indeed, that looks like a bug. We'll get that fixed up.

@dchester dchester closed this in 88af559 Mar 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.