Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add a bower.json file #361

Closed
halloffame opened this Issue · 4 comments

3 participants

Ryan Hall Ændrew Rininsland Dave Jensen
Ryan Hall

Installing rickshaw with bower includes everything. It would be nice if you added a bower.json file to ignore all but the source files.

http://bower.io/

Ændrew Rininsland

+1 I noticed this the other day. I might do a pull request if it's all the same to y'all.

Dave Jensen

+1 :+1:

Also, at one point (a few days ago) Rickshaw was actually in bower, but it's not there anymore. Weird.

Ændrew Rininsland aendrew referenced this issue from a commit in aendrew/rickshaw
Ændrew Rininsland aendrew Adding bower.json file. Fixes #361. 0f27076
Ændrew Rininsland aendrew referenced this issue from a commit in aendrew/rickshaw
Ændrew Rininsland aendrew Adding bower.json file. Fixes #361. 83aa9df
Ændrew Rininsland

This is done as per the above PR.

Testing with generator-angular, Yeoman's bower-install task correctly injects both rickshaw.css and rickshaw.js into the appropriate block (which was my primary reason for wanting it, anyway).

@halloffame — could you please inspect the "ignore" stanza and make sure I've properly set everything? I've ignored the "vendor" folder because I've assumed one would use bower to manage d3 anyway if you're installing via that.

Ændrew Rininsland aendrew referenced this issue from a commit in aendrew/rickshaw
Ændrew Rininsland aendrew Adding bower.json file. Fixes #361. 680d105
Ryan Hall

:+1: That seems right to me, thanks!

Ryan Hall halloffame closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.