Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add a bower.json file #361

Closed
halloffame opened this Issue Dec 5, 2013 · 7 comments

Comments

Projects
None yet
4 participants

Installing rickshaw with bower includes everything. It would be nice if you added a bower.json file to ignore all but the source files.

http://bower.io/

aendrew commented Apr 29, 2014

+1 I noticed this the other day. I might do a pull request if it's all the same to y'all.

+1 👍

Also, at one point (a few days ago) Rickshaw was actually in bower, but it's not there anymore. Weird.

aendrew added a commit to aendrew/rickshaw that referenced this issue Aug 3, 2014

aendrew added a commit to aendrew/rickshaw that referenced this issue Aug 3, 2014

aendrew commented Aug 3, 2014

This is done as per the above PR.

Testing with generator-angular, Yeoman's bower-install task correctly injects both rickshaw.css and rickshaw.js into the appropriate block (which was my primary reason for wanting it, anyway).

@halloffame — could you please inspect the "ignore" stanza and make sure I've properly set everything? I've ignored the "vendor" folder because I've assumed one would use bower to manage d3 anyway if you're installing via that.

aendrew added a commit to aendrew/rickshaw that referenced this issue Aug 3, 2014

👍 That seems right to me, thanks!

@halloffame halloffame closed this Aug 5, 2014

drakonen added a commit to drakonen/rickshaw that referenced this issue Oct 2, 2014

What's the proper way to have these scripts injected by bower/gulp? I created a bower.json file manually to fix my app before finding this closed issue. I'm confused now what I should have done if anything.

aendrew commented Nov 26, 2015

@findkiko Bower is being used increasingly less in frontend development due to the advent of libraries like Webpack and Browserify, which bundle dependencies effectively and remove reliance on attaching dependencies to the browser global object. While I'd recommend to go this route, if you're using Wiredep or main-bower-files, you can still install any dependency via GitHub shortname (I.e., bower install shutterstock/rickshaw) and then specify the library's main entry points in your bower.json file. See docs for bower-main-files and wiredep.

OK, thanks for the pointer. I'm modifying an existing code-base that uses wiredep so did end up figuring out the solution you mention eventually (adding a main clause).

@findkiko findkiko referenced this issue in DecentralVan/numerator Jan 20, 2016

Open

Fix rickshaw bower workaround #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment