MultiRenderer doesn't respect .domain() implementation of subrenderers #377

Closed
dwt opened this Issue Jan 14, 2014 · 0 comments

Projects

None yet

1 participant

@dwt
Contributor
dwt commented Jan 14, 2014

The problem is on https://github.com/shutterstock/rickshaw/blob/master/src/js/Rickshaw.Graph.Renderer.Multi.js#L45 where it calls $super instead of group.renderer.domain(data).

Thus if a Renderer overrides domain() it is not called.

In our use case we have a renderer for a different data format (y, yMin, yMax) and Renderer.domain() doesn't know about that....

@dchester dchester pushed a commit that closed this issue Jan 15, 2014
@dwt dwt Fix #377: Ensure multi renderer consults it's sub renderers about how…
… they perceive their domain
6e52a83
@dchester dchester closed this in 6e52a83 Jan 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment