Y-Axis sizing issue in render function #380

Open
ShimiSun opened this Issue Jan 15, 2014 · 0 comments

Comments

Projects
None yet
1 participant

Hi,

In rickshaw 1.4.5 there was a fix in the renedering function of the y-axis.
The line (from a previous rickshaw version):
if (this.graph.height !== this._renderHeight) this.setSize({ auto: true });
Was replaced with:
if (this._renderHeight !== undefined && this.graph.height !== this._renderHeight) this.setSize({ auto: true });

Can you please elaborate on why you added the check of: "this._renderHeight!==undefined &&", this check is causing us regressions when "this._renderHeight==undefined" and the size isn't being auto calculated like it used too and the chart loses the layout.

The auto resizing is important for the chart layout and adding this condition will omit the auto resizing.
Please advise.

Thanks,
Shimi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment