Fix package.json #222

Merged
merged 2 commits into from Apr 17, 2013

Conversation

Projects
None yet
3 participants
Contributor

chrisirhc commented Mar 28, 2013

  • Allow tests to be run by simply npm test
  • Add devDependencies so that everything needed to build/test is set up after running npm install

chrisirhc added some commits Mar 28, 2013

@chrisirhc chrisirhc Fix package.json
- Allow tests to be run by simply `npm test`
- Add devDependencies
20a7df8
@chrisirhc chrisirhc Fix major version of d3 to v2
The current version of Rickshaw has been thoroughly tested with
version 2 of d3 not with version 3 of d3.

Rickshaw unit tests are not compatible with the latest changes in d3.
See d3/d3#1044 for discussion.

References:

- About tilde version ranges: https://npmjs.org/doc/json.html
009d1a8
Contributor

chrisirhc commented Mar 28, 2013

Unit tests are now running fine (100%) after doing npm install since d3 v3 has some breaking changes to the way d3 behaves in node (see mbostock/d3#1044 for a discussion on this).

I think for now it's fine to restrict it to the latest d3 version 2 builds since that's also included in this package and d3 v3 hasn't been thoroughly tested with Rickshaw.

will-ob commented Mar 28, 2013

++++

@dchester dchester added a commit that referenced this pull request Apr 17, 2013

@dchester dchester Merge pull request #222 from chrisirhc/feature/fix-package-json
Update package.json
6415eab

@dchester dchester merged commit 6415eab into shutterstock:master Apr 17, 2013

Contributor

dchester commented Apr 17, 2013

Thanks much.

chrisirhc deleted the chrisirhc:feature/fix-package-json branch Apr 17, 2013

@cesine cesine added a commit to cesine/rickshaw that referenced this pull request Aug 23, 2016

@bozdoz @cesine bozdoz + cesine Multi-chart slider and colors for individual bars
RangeSlider now works with multiple charts and a single slider, by using an array with the graph variables:

var slider_three = new Rickshaw.Graph.RangeSlider({
    element: document.querySelector('#slider-range'),
    graph: [graph_one, graph_two, graph_three]
});

The bar chart renderer now looks for a proposed color for each individual bar, it will default to the chart-specific color if no color is declared:

var data = [{
  data: [{ 
    x: -1893456000, y: 29389330}, { 
    x: -1577923200, y: 33125803}, { 
    x: -1262304000, y: 37857633, color:'#06f'}, { 
    x: -946771200, y: 41665901, color:'#0cf'}
  ],
    color: '#222'
  }]
632d1fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment