Prevent slider from cutting off series. #390

Merged
merged 1 commit into from Nov 7, 2016

Projects

None yet

2 participants

@arunv
Contributor
arunv commented Feb 12, 2014

This fixes what I think is a bug:

I have 4 series,

[
[{0, 1}, {1, 1}],
[{1, 1}, {2, 1}],
[{2, 1}, {3, 1}],
[{3, 1}, {4, 1}]
]

I use a slider to select the x-range (2.5, 4)

This means stackedData ends up being

[ [], [], [], [[3,4], [1, 1]] ]

At this point, reading stackedData[0][0] produces undefined, even though
there is data that belongs to the range.

@arunv arunv Prevent slider from cutting of series.
This fixes the following bug:

I have 4 series,

[
  [{0, 1}, {1, 1}],
  [{1, 1}, {2, 1}],
  [{2, 1}, {3, 1}],
  [{3, 1}, {4, 1}]
]

I use a slider to select the x-range (2.5, 4)

This means stackedData ends up being

[ [], [], [], [[3,4], [1, 1]] ]

At this point, reading stackedData[0][0] produces undefined, even though
there is data that belongs to the range.
63436fe
@cesine cesine self-assigned this Apr 8, 2016
@cesine cesine merged commit 63436fe into shutterstock:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment