Fix typeof check in Graph.js #398

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@aron
aron commented Feb 24, 2014

This was incorrectly checking that typeof window was not undefined, this will always return true, as typeof always returns a string.

I couldn't see a good place to add a unit test for this change, if you have a suggestion, I'd be happy to add one. Also I have two tests failing on master when I run the tests locally, these fail before and after the application of this patch.

@aron aron fix typeof check in Graph.js
This was incorrectly checking that typeof window was not undefined,
which will always return true, as typeof always returns a string.
6313b6b
@dpobel
dpobel commented Sep 13, 2014

Hi,

anybody willing to merge this PR ? this issue prevents the usage of Rickshaw server side (with jsdom).

@aron
aron commented Dec 7, 2014

It's been nearly a year, closing due to lack of interest.

@aron aron closed this Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment