Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement label for Y Axis Add editorconfig file #404

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants

Following changes are made:

  • implement label for Y Axis, support customize of text, font, color, offsets, issue #307
  • add editor config file for unifying code formatting

labels for x axis currently is not supported

frco9 pushed a commit to frco9/rickshaw that referenced this pull request Mar 26, 2014

Add label to yAxis
Credits to wangshijun2010, pull request #404

maxd commented Jul 1, 2014

@dchester Could you please verify this PR and comment your opinion about it? I think this is very useful feature.

@drakonen drakonen commented on the diff Oct 2, 2014

.editorconfig
@@ -0,0 +1,21 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+
+[*]
+
+# Change these settings to your own preference
+indent_style = space
@drakonen

drakonen Oct 2, 2014

Rickshaw source code is indented with tabs!

drakonen commented Oct 2, 2014

2 things in one PR is probably not the best idea

Contributor

wilmoore commented Mar 25, 2016

@wangshijun If you are still interested in getting this PR in, would you mind submitting a separate PR for the editorconfig?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment