Add src/js/Rickshaw.Graph.Axis.X.js, X axis based off .x values in data.... #73

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@timob

timob commented Jun 12, 2012

... Works like Rickshaw.Graph.Axis.Y.js

@dchester

This comment has been minimized.

Show comment Hide comment
@dchester

dchester Jun 15, 2012

Contributor

Thanks -- there are some tweaks I think we want to make before merging this in. If you don't specify an element in the constructor, I think we want the ticks to end up inside along the bottom of the graph, rather than at the top. There also may or may not be some good opportunity to have both X and Y axes inherit from a parent Axis class. We should also add an example or two to show how this works.

Contributor

dchester commented Jun 15, 2012

Thanks -- there are some tweaks I think we want to make before merging this in. If you don't specify an element in the constructor, I think we want the ticks to end up inside along the bottom of the graph, rather than at the top. There also may or may not be some good opportunity to have both X and Y axes inherit from a parent Axis class. We should also add an example or two to show how this works.

@kalebdf

This comment has been minimized.

Show comment Hide comment
@kalebdf

kalebdf Aug 11, 2012

What is the status on including this crucial 2nd configurable Axis (regardless of inheriting from a parent Axis or not)?

kalebdf commented Aug 11, 2012

What is the status on including this crucial 2nd configurable Axis (regardless of inheriting from a parent Axis or not)?

@timob

This comment has been minimized.

Show comment Hide comment
@timob

timob Aug 21, 2012

You can use my patch above in the mean time.

I can make the changes above for the default position and an example if @dchester is wanting to add this to the project.

timob commented Aug 21, 2012

You can use my patch above in the mean time.

I can make the changes above for the default position and an example if @dchester is wanting to add this to the project.

@praveen21

This comment has been minimized.

Show comment Hide comment
@praveen21

praveen21 Aug 29, 2012

where can i find your patch ??

where can i find your patch ??

@praveen21

This comment has been minimized.

Show comment Hide comment
@praveen21

praveen21 Aug 29, 2012

Thanks for commiting.....can you add an example using this .js ?

I have added this file but its error message as Uncaught TypeError: undefined is not a function . should i need to add anything to rickshaw.js ?

Actually I want to pass strings to the x-axis.

like {x:"2012-03-20", y:20};

please help me......

Thanks for commiting.....can you add an example using this .js ?

I have added this file but its error message as Uncaught TypeError: undefined is not a function . should i need to add anything to rickshaw.js ?

Actually I want to pass strings to the x-axis.

like {x:"2012-03-20", y:20};

please help me......

@djcoin

This comment has been minimized.

Show comment Hide comment
@djcoin

djcoin Jan 9, 2013

5 month later, your patch is still not merged, too bad, I think it may be useful for many people (including me ! :) ).
Cheers !

djcoin commented Jan 9, 2013

5 month later, your patch is still not merged, too bad, I think it may be useful for many people (including me ! :) ).
Cheers !

@timob

This comment has been minimized.

Show comment Hide comment
@timob

timob Jan 15, 2013

dchester if these changes are made as you suggested:

If you don't specify an element in the constructor, I think we want the ticks to end up inside along the bottom of the graph, rather than at the top.
We should also add an example or two to show how this works.

Would you pull the change?

timob commented Jan 15, 2013

dchester if these changes are made as you suggested:

If you don't specify an element in the constructor, I think we want the ticks to end up inside along the bottom of the graph, rather than at the top.
We should also add an example or two to show how this works.

Would you pull the change?

@dchester

This comment has been minimized.

Show comment Hide comment
@dchester

dchester Jan 17, 2013

Contributor

Yes, Rickshaw could definitely benefit from some version of a Rickshaw.Graph.Axis.X class, like we have for the y-axis.

I also have a branch around with a good start on the parent class and x and y implementations inheriting. I'll take another look and see how that was shaping up.

Contributor

dchester commented Jan 17, 2013

Yes, Rickshaw could definitely benefit from some version of a Rickshaw.Graph.Axis.X class, like we have for the y-axis.

I also have a branch around with a good start on the parent class and x and y implementations inheriting. I'll take another look and see how that was shaping up.

@dchester

This comment has been minimized.

Show comment Hide comment
@dchester

dchester Jan 21, 2013

Contributor

We now have Rickshaw.Graph.Axis.X with 30fa2c2.

As with the y-axis, specify an element and orientation to place the axis outside the graph, or leave them out to get the default inside option. Example here: http://code.shutterstock.com/rickshaw/examples/x_axis.html

Contributor

dchester commented Jan 21, 2013

We now have Rickshaw.Graph.Axis.X with 30fa2c2.

As with the y-axis, specify an element and orientation to place the axis outside the graph, or leave them out to get the default inside option. Example here: http://code.shutterstock.com/rickshaw/examples/x_axis.html

@dchester dchester closed this Jan 21, 2013

@ches ches referenced this pull request Jul 22, 2013

Closed

Axis should use d3.svg.axis #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment