Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Startup Tuning]LPS-96854 #7925

Closed
wants to merge 192 commits into from
Closed

[Startup Tuning]LPS-96854 #7925

wants to merge 192 commits into from

Conversation

@tinatian
Copy link

tinatian commented Jun 13, 2019

No description provided.

wincent and others added 30 commits Jun 12, 2019
Updates us to v3.0.0 of liferay-npm-scripts which means:

- New version of Prettier, which leads to a small number of formatting
  changes included in this commit.
- Renamed subcommands ("lint" is now "check", "format" is now "fix") for
  reasons described in: liferay/liferay-npm-tools#110
- New "lint" subcommand that enables us to manually run ESLint. We need
  to clean things up before turning this on automatically. There are
  over 12,000 lints in all of liferay-portal right now; over 7,000 of
  those are "autofixable", and many others will go away once we complete
  an audit of globals etc. The remaining ones will be legitimate lints
  that we can tackle, and then we'll bake "lint" into the automated
  "check" run.
- Because different tools understand globs differently, I simplified the
  globs to a "lowest common denominator" that they all understand. An
  example necessary change is moving some ignores from globs into
  ".prettierignore" and ".eslintignore" because ESLint doesn't support
  negated globs in the way that Prettier does.

Along the way, simplified some "npmscripts.config.js" files, and removed
some which are now unnecessary because they exactly match the defaults.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jun 13, 2019

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@tinatian

This comment has been minimized.

Copy link
Author

tinatian commented Jun 13, 2019

ci:test:relevant

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jun 13, 2019

ci:test:relevant - 87 out of 95 jobs passed in 1 hour 28 minutes 52 seconds 902 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 08699f941b926aa717faf6f37dcf95c2a940911b

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 65a45df9fdc7a041e61a9206a1d81e4afb43abc8

87 out of 95 jobs PASSED
87 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 7dbe984:
  1. ...
@shuyangzhou

This comment has been minimized.

Copy link
Owner

shuyangzhou commented Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.