Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with x-st of month #3

Closed
sjurba opened this issue Dec 11, 2018 · 2 comments
Closed

Doesn't work with x-st of month #3

sjurba opened this issue Dec 11, 2018 · 2 comments

Comments

@sjurba
Copy link
Contributor

sjurba commented Dec 11, 2018

val schedule = parse("first monday of month 09:00");
Fails:

Exception in thread "main" com.github.shyiko.skedule.InvalidScheduleException: "month" isn't a valid month
	at com.github.shyiko.skedule.internal.ScheduleImpl.parseMonth(ScheduleImpl.kt:113)
	at com.github.shyiko.skedule.internal.ScheduleImpl.parse(ScheduleImpl.kt:173)
	at com.github.shyiko.skedule.Schedule.parse(Schedule.java:36)
	at no.entro.subscriptions.scheduling.SchedulerKt.main(Scheduler.kt:8)
	at no.entro.subscriptions.scheduling.SchedulerKt.main(Scheduler.kt)
sjurba added a commit to sjurba/skedule that referenced this issue Dec 11, 2018
sjurba added a commit to sjurba/skedule that referenced this issue Dec 11, 2018
sjurba added a commit to sjurba/skedule that referenced this issue Dec 11, 2018
@sjurba sjurba changed the title Doesn't work with x-st of every month Doesn't work with x-st of month Dec 11, 2018
@sjurba
Copy link
Contributor Author

sjurba commented Dec 11, 2018

FTR. I know you can use "first monday 09:00" instead, but using "of month" is more clear and is also supported and documented by GAE.

@shyiko shyiko closed this as completed in #4 Dec 18, 2018
@shyiko
Copy link
Owner

shyiko commented Dec 18, 2018

Included in 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants