Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered deprecated event. [Needs to patched in 1.12_R2 or 1.13_R1] #29

Closed
mibby opened this issue Jul 29, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@mibby
Copy link

mibby commented Jul 29, 2017

Paper dev 1167 (Spigot 1.12)

[22:04:56] [Server thread/WARN]: [BlockBall] "BlockBall v4.0.1" has registered a listener for org.bukkit.event.player.PlayerPickupItemEvent on method "public void com.github.shynixn.blockball.business.logic.game.GameListener.onItemPickUpEvent(org.bukkit.event.player.PlayerPickupItemEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Shynixn].
@Shynixn
Copy link
Owner

Shynixn commented Jul 29, 2017

Thanks for reporting!

Seems like the latest spigot build from this week set the PlayerPickUpItemEvent deprecated. It should be replaced with EntityPickupItemEvent.

As this is a Bukkit-Api change during one version, I cannot simply replace the events as the plugin would crash when someone uses a 1.12_R1 build downloaded previously. It doesn't harm the server when the event is still present as the event performance did not increase.

However I'll definitely patch this when 1.12_R2 or 1.13_R1 gets released.

@Shynixn Shynixn self-assigned this Jul 29, 2017
@Shynixn Shynixn changed the title Registered deprecated event. Registered deprecated event. [Needs to patched in 1.12_R2 or 1.13_R1] Jul 29, 2017
@Shynixn
Copy link
Owner

Shynixn commented May 22, 2018

Actually, this issue is no longer present in the BlockBall remake.

@Shynixn Shynixn closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants