Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Conversation doesn't close the connection for file transfers over S5B #3500
Unlike the IBB, file transfers over socks5 do not close the stream when the file is completely sent. This seems like an inconsistency.
I don't know how exactly one is supposed to detect that a file transfer is finished, but "peer closed the connection" and "peer send
Steps to reproduce
Socks5 connection is closed.
Socks5 connection remains open, waiting for the receiver to terminate the Jingle session.
Not provided, can add if wanted.
It's an inconsistency between the behavior of in-band bytestreams and s5b.
I'm not entirely sure whether the behavior of IBB or s5b is the correct one. Closing the (IBB/SOCKS5, not Jingle) connection after the file is completely sent gives the receiver an easy way to check whether the file has been completely sent.