Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOCKS5 to IBB fallback as responder: bad transport info in `transport-accept` #3514

Closed
hrxi opened this issue Aug 6, 2019 · 0 comments

Comments

@hrxi
Copy link

commented Aug 6, 2019

The transport info in transport-accept can contain a blocksize larger than what the transport-replace specified. Also, it does not contain a sid attribute. I found no hint in the XEP whether the sid attribute is required, but it is present in the example.

General information

  • Version: 2.5.5+fcr
  • Device: Nexus 5X
  • Android Version: Android 8.1 (LineageOS 15.1)
  • Server name: from jabber.ccc.de to 5222.de
  • Server software: not known
  • Installed server modules: not known
  • Conversations source: F-Droid

Steps to reproduce

  1. Offer a file to Conversations.
  2. Make sure that all SOCKS5 candidates fail. Send a <candidate-error /> and wait for Conversations' <candidate-error />.
  3. Send a transport-replace with a blocksize smaller than 8192.
<iq id='ef311236-9813-4001-b060-93179d64b571' type='set' to='responder@jabber.ccc.de/Conversations.aSP7'>
  <jingle xmlns='urn:xmpp:jingle:1' action='transport-replace' sid='167f9b91-709c-4bf0-8b0c-77c6efe3866e'>
    <content creator='initiator' name='a-file-offer'>
      <transport xmlns='urn:xmpp:jingle:transports:ibb:1' block-size='4096' sid='105c076d-b610-48d8-a12d-772f4441af1a' />
    </content>
  </jingle>
</iq>

Expected result

Conversations reacts with a blocksize that the peer specified and includes the sid.

Actual result

Conversations sends a blocksize that is too high and omits the sid:

<iq type='set' to='initiator@5222.de/dino.ffd8e29b' from='responder@jabber.ccc.de/Conversations.aSP7' id='MVmKAsPGcVCe' lang='en'>
  <jingle xmlns='urn:xmpp:jingle:1' initiator='initiator@5222.de/dino.ffd8e29b' action='transport-accept' sid='167f9b91-709c-4bf0-8b0c-77c6efe3866e'>
    <content creator='initiator' senders='initiator' name='a-file-offer'>
      <description xmlns='urn:xmpp:jingle:apps:file-transfer:5'>
        <file>
          <name>
            6fae08ad_d050d4c8-8ec2-4344-b34b-2ba0f0bdc627.jpg
          </name>
          <size>
            3801
          </size>
        </file>
      </description>
      <transport block-size='8192' xmlns='urn:xmpp:jingle:transports:ibb:1' />
    </content>
  </jingle>
</iq>

Debug output

Not provided.

@hrxi hrxi changed the title IBB to SOCKS5 fallback as responder: bad transport info in `transport-accept` SOCKS5 to IBB fallback as responder: bad transport info in `transport-accept` Aug 6, 2019

@iNPUTmice iNPUTmice closed this in 8ac0424 Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.