Permalink
Switch branches/tags
Commits on Sep 14, 2012
  1. merged branch brikou/patch-2 (PR #62)

    fabpot committed Sep 14, 2012
    Commits
    -------
    
    dd4b108 Update Resources/skeleton/app/SymfonyRequirements.php
    
    Discussion
    ----------
    
    [cs] Resources/skeleton/app/SymfonyRequirements.php
    
     fixed trailing space
  2. Update Resources/skeleton/app/SymfonyRequirements.php

    brikou committed Sep 14, 2012
    [cs] fixed trailing space
Commits on Sep 11, 2012
  1. updated build script

    fabpot committed Sep 11, 2012
  2. fixed build script

    fabpot committed Sep 11, 2012
Commits on Sep 7, 2012
  1. merged branch cvschaefer/master (PR #61)

    fabpot committed Sep 7, 2012
    Commits
    -------
    
    8b477bc Update Resources/skeleton/app/SymfonyRequirements.php
    
    Discussion
    ----------
    
    Corrected suhosin detection
    
    The phpinfo test is not accurate.
    See http://www.hardened-php.net/suhosin/index.html
    > Suhosin comes in two independent parts, that can be used separately or in combination. The first part is a small patch against the PHP core, that implements a few low-level protections against bufferoverflows or format string vulnerabilities and the second part is a powerful PHP extension that implements all the other protections.
    
    and
    
    > When you only use the Suhosin-Patch only the logging features are supported. When you only use the Suhosin-Extension you cannot use the predefined constants for configuration.
    
    Searching for Suhosin in phpinfo leads to false positives when the core patch is applied and the extension is not loaded / compiled into php.
    The suhosin.executor.include.whitelist option is only used by the extension and not by the core patch.
    extension_loaded also works with compiled in extensions.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-09-07T05:56:22Z
    
    ping @tobion.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-09-07T06:38:28Z
    
    Yeah its ok. Already answered at symfony/symfony-standard#401 and symfony/symfony#5444
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-09-07T06:44:59Z
    
    > extension is not loaded / compiled into php
    
    @cvschaefer Does it mean the extension could also be compiled into php, which would not be the same as a loaded extension?
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2012-09-07T09:09:05Z
    
    Looks good. FYI in composer we do the check like this because ini_get on an invalid param returns false, while it should return "" for a valid one that is not configured.
    
    ```
        $suhosin = ini_get('suhosin.executor.include.whitelist');
        if (false !== $suhosin && false === stripos($suhosin, 'phar')) {
            $errors['suhosin'] = $suhosin;
        }
    ```
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-09-07T12:25:46Z
    
    i recommand you to read sektioneins/suhosin#4 (comment)
Commits on Sep 6, 2012
  1. Update Resources/skeleton/app/SymfonyRequirements.php

    cvschaefer committed Sep 6, 2012
    Accurate Suhosin detection.
Commits on Sep 5, 2012
  1. tweaked an error message

    fabpot committed Sep 5, 2012
  2. merged branch Tobion/patch-4 (PR #60)

    fabpot committed Sep 5, 2012
    Commits
    -------
    
    0b9fc9d improve the requirement checks
    4f09dab fix phpdoc of SymfonyRequirements
    
    Discussion
    ----------
    
    optimize SymfonyRequirements
    
    fix phpdoc of SymfonyRequirements
    improve the requirement checks
    - reordered the requirements to make more sense
    - improve wording, e.g. a test message like "OK  Your project might not work properly ..." is very confusing when the requirement is fulfilled.
    - made some tests conditional so that a requirement is only checked when necessary (otherwise it's misleading). E.g. only check Suhosin config, when Suhosin is installed.
    - fixed compatibility with PHP 5.2
Commits on Sep 2, 2012
  1. improve the requirement checks

    Tobion committed Sep 2, 2012
    - reordered the requirements to make more sense
    - improve wording, e.g. a test message like "OK  Your project might not work properly ..." is very confusing when the requirement is fulfilled.
    - made some tests conditional so that a requirement is only checked when necessary (otherwise it's misleading). E.g. only check Suhosin config, when Suhosin is installed.
    - fixed compatibility with PHP 5.2
Commits on Aug 29, 2012
  1. reworked the build.sh script to create archives that works fine with …

    fabpot committed Aug 29, 2012
    …composer (no removed .git in vendors)
Commits on Aug 26, 2012
  1. added some xdebug requirements

    fabpot committed Aug 26, 2012
  2. merged branch vurtupesz/master (PR #59)

    fabpot committed Aug 26, 2012
    Commits
    -------
    
    178d87d fix php warning
    
    Discussion
    ----------
    
    Fix a php warning
    
    The PR #48 generate a PHP Warning.
    I fix it in this one.
    
    Sorry for this stupid error ...
    
    It's related to the issue #58
Commits on Aug 25, 2012
  1. fix php warning

    tpointel committed Aug 25, 2012
Commits on Aug 24, 2012
  1. tweaked message

    fabpot committed Aug 24, 2012
  2. merged branch vurtupesz/master (PR #48)

    fabpot committed Aug 24, 2012
    Commits
    -------
    
    1868931 Test intl configuration
    
    Discussion
    ----------
    
    [2.1] Intl - Collator problem on WAMP & PHP 5.3.8
    
    Add recommendation on check
    
    This PR is related to my other on symfony/symfony : symfony/symfony#5021
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-07-23T22:04:48Z
    
    Ok, sorry, it's done !
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-07-24T09:06:22Z
    
    Oh wait !
    I seem have the same problem on PHP 5.3.13 ... :(
    I try to upgrade to PHP 5.4.X, and look if problem always exists
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-07-24T09:49:56Z
    
    @vurtupesz are you using the x86 or the x64 build of WAMP ?
    It works for me on 5.3.10, but I switched to the x86 build at the same time. Maybe all their x64 builds are affected ?
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-07-24T09:50:53Z
    
    Yes, I use x64 with WampServer
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-07-24T10:10:00Z
    
    Ok, I did a custom installation of Apache 2.2 / PHP 5.4.5 without WampServer and problem is solved.
    I try with a PHP 5.3.X version on my custom installation, view if problem is linked with WampServer or if it's just PHP problem
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-07-24T10:32:59Z
    
    Ok, problem seem to be linked with WampServer.
    I tried with PHP 5.3.8 and 5.3.15 on custom configuration ... and no problem !
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-06T08:16:06Z
    
    IIUC, this is only when using Wamp, so the check should take that into account. Is it possible to detect that PHP comes from WampServer?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-06T08:49:32Z
    
    @fabpot In fact, I suspect it is more linked to the x64 build than to Wampserver itself. A x86 WAMP works fine, and I think the custom installation tried by @vurtupesz was also a x86 one as the official PHP site does not provide x64 binaries.
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-06T08:54:36Z
    
    Oh indeed ! My new WAMP Installation is x86 :/
    That's probably the problem ...
    Do you know where can I find x64 binaries for test ?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-06T08:56:45Z
    
    @vurtupesz As I said above, there is no official x64 binaries for Windows. The PHP team explicitly said they don't want to provide them when I asked. So if you want a x64 build different from the WAMP ones, I think you will have to compile PHP yourself
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-23T13:09:17Z
    
    Any news on this PR?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-23T13:16:43Z
    
    Well, a better test would be to detect a x64 build on windows (as 5.3.8 is not the real condition)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-23T13:17:27Z
    
    You mean that this is about all x64 windows builds?
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-23T13:20:43Z
    
    Unfortunately it's difficult to test on a php version x64 without WAMPServer.
    For sure, this problem is present on all x64 (5.3.X) builds from WAMPServer.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-23T13:22:00Z
    
    it seems to be about all WAMP x64 builds at least.
    On the other hand, there is no official x64 build for windows (the PHP team told me it is not even planned) so I'm not sure there is other tools than WAMP providing x64 builds
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-23T13:23:03Z
    
    ok, so let's limit the test to x64 builds and only for people using WAMP servers. Is it possible to detect that the developer is using a WAMP server?
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-23T13:28:13Z
    
    There are no information about WampServer in phpinfo()
    It's look difficult to test it.
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-23T21:45:31Z
    
    I pushed a new test with integration of our discussion
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-24T08:34:16Z
    
    I applied @stof 's recommandations
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-24T08:34:29Z
    
    Can you squash you commits before I merge? Thanks.
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-24T08:49:13Z
    
    Okay it's done
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-24T08:52:52Z
    
    hmm, something wrong happened, I still see more than one commits. Can you check?
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-24T09:14:46Z
    
    Ok, sorry. I'm a github beginner :)
    I look at this a little more late
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-24T09:24:23Z
    
    You can have a look at the documentation we have on this topic: http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch
    
    ---------------------------------------------------------------------------
    
    by vurtupesz at 2012-08-24T13:30:51Z
    
    Okay ! Thanks for your help.
    It's good now !
  3. Test intl configuration

    vurtupesz authored and tpointel committed Jul 23, 2012
Commits on Aug 16, 2012
  1. merged branch mazen/php-61453 (PR #55)

    fabpot committed Aug 16, 2012
    Commits
    -------
    
    6c6bad4 * Emit warning on PHP Versions older than 4.5.1 (symfony/symfony#4965)
    
    Discussion
    ----------
    
    Emit warning on PHP Versions older than 4.5.1
    
    Causing some issues in the symfony/symfony repo which are quite hard to debug  (symfony/symfony#4965)
    
    ---------------------------------------------------------------------------
    
    by mazen at 2012-08-13T13:35:42Z
    
    You are right. Tested using http://3v4l.org/vHuEv yields that only 5.4.0 is affected
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-13T14:23:35Z
    
    Can you squash your commits before I merge? Thanks.
    
    ---------------------------------------------------------------------------
    
    by mazen at 2012-08-16T16:37:58Z
    
    in case it got missed, 6c6bad4 is the cleaned up version
Commits on Aug 14, 2012
  1. fixed typos

    fabpot committed Aug 14, 2012
Commits on Aug 13, 2012
Commits on Aug 6, 2012
  1. merged branch Tobion/patch-3 (PR #52)

    fabpot committed Aug 6, 2012
    Commits
    -------
    
    853187c fix deprecated method
    
    Discussion
    ----------
    
    fix deprecated method
  2. merged branch Tobion/patch-2 (PR #51)

    fabpot committed Aug 6, 2012
    Commits
    -------
    
    91cda18 fix symfony/symfony#5185
    
    Discussion
    ----------
    
    fix symfony/symfony#5185
    
    fix symfony/symfony#5185
Commits on Aug 5, 2012
  1. fix deprecated method

    Tobion committed Aug 5, 2012
  2. fix symfony/symfony#5185

    Tobion committed Aug 5, 2012
Commits on Aug 3, 2012
  1. merged branch lsmith77/sqlite_support (PR #49)

    fabpot committed Aug 3, 2012
    Commits
    -------
    
    9409b94 added path setting and made name/user/password optional
    5886ada added a recommendation to use PHP 5.3.4 or newer
    
    Discussion
    ----------
    
    added path setting and made name/user/password optional
    
    fixes #6
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2012-08-01T21:08:16Z
    
    getting this merged would be cool so that i could enable the configurator for https://github.com/symfony-cmf/symfony-cmf-standard
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-08-02T14:11:11Z
    
    👍
Commits on Aug 1, 2012
Commits on Jul 15, 2012
Commits on Jul 13, 2012
  1. merged branch Fran6co/fix-timeout (PR #46)

    fabpot committed Jul 13, 2012
    Commits
    -------
    
    fd46abe proccess timeout fix. The hooks are not honoring the composer default.
    b2b18d7 made an error message clearer (closes symfony/symfony#4786)
    9a7dbd8 removed file in skeleton
    0a07570 fixed typo
    8ae53fb added more files that need to be auto-updated
    c1780bd added a caution in the SymfonyRequirements.php file
    dfd0856 fixed typo
    5504919 fixed explanation
    d6908c5 added the Requirements file to be able to automatically update it
    e5f4874 added missing classes in CSS
    
    Discussion
    ----------
    
    Proccess timeout fix
    
    Now it should honor the composer setting
Commits on Jul 12, 2012
Commits on Jul 10, 2012
Commits on Jul 8, 2012
  1. removed file in skeleton

    fabpot committed Jul 8, 2012