Fix helm initial disk creation process and add installation instructions #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sickcodes
approved these changes
Jan 15, 2021
|
Fantastic, thank you! |
|
I've signed up to artifacthub, will need to work out the index.yaml. This is helm v2 right? |
|
Yes, its helm v2. I have another PR coming soon with a ton of changes and more features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes initial disk creation and adds more installation instructions.
I'm not sure how it worked before on a new install, as it didn't for me when I attempted to rerun it, but here's a version with that fixed and more detailed instructions on it.
Also, I added some more parameters, such as software gpu, system installer version, etc. I am working on getting hardware passthrough gpu support added as well. It may work, but I don't have hardware to test it right now so I left comments saying it's probably broken for the time being.
P.S. Feel free to register at Helm if you haven't already. Thank you!