Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorizationConfig to HTTP datasource #238

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@yai333
Copy link

yai333 commented Apr 10, 2019

Description

It is now possible to provide AuthorizationConfig as part of the HTTP data source configuration in cloud formation from recent release of AWS.

Reference

https://docs.aws.amazon.com/appsync/latest/APIReference/API_AuthorizationConfig.html

This pull request adds AuthorizationConfig to HTTP data source configuration.

Example of configuration as below:

      - type: HTTP
        name: AWSSES
        description: "send email"
        config:
          endpoint: "https://email.us-east-1.amazonaws.com/"
          authorizationConfig:
            authorizationType: "AWS_IAM"
            awsIamConfig:
              signingRegion: "us-east-1"
              signingServiceName: "ses"
          serviceRoleArn: { Fn::GetAtt: [AppSyncSESserviceRole, Arn] }
          

Type of change

  • New feature
@bboure

This comment has been minimized.

Copy link
Collaborator

bboure commented Apr 10, 2019

Thank you @yai333 for bringing this!
Code LGTM. Could you please add tests for this?

yai333 added some commits Apr 10, 2019

@yai333

This comment has been minimized.

Copy link
Author

yai333 commented Apr 11, 2019

Added test as per requested

Show resolved Hide resolved index.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.