New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well... lots of stuff, see comment #12

Merged
merged 4 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@lociii
Contributor

lociii commented Nov 2, 2018

  • Completely restructured code in small functions
  • Add lots of error handling when BLE stuff fails
  • Support multiple devices
  • Add device retry
  • Change how deep sleep is activated (no more unwanted sleep while devices are still updated)
  • Add emergency deep sleep handler in case something gets stuck (should use a quite long delay)
  • Make log output easier to read
  • Properly disconnect services

Guess that's all :-)

The reboot issues noted in #9 and #10 are handled with these updates.

@sidddy sidddy self-requested a review Nov 2, 2018

@sidddy

This comment has been minimized.

Owner

sidddy commented Nov 2, 2018

Wow, that's great!! Lots of stuff in there which I had planned to do, but never found time... I'll review the changes soon!

@sidddy

Again, thanks for this contribution, looks very nice overall!! Just one minor thing: Could you change the coding for the emergency interval to really use a "seconds" value for the EMERGENCY_HIBERNATE define?

I'll still have to verify that the code actually works with my flora device, but I'm optimistic ;-)

Show resolved Hide resolved flora/config.h.example Outdated
Show resolved Hide resolved flora/flora.ino Outdated
Show resolved Hide resolved flora/flora.ino
Show resolved Hide resolved flora/flora.ino

sidddy and others added some commits Nov 9, 2018

Update flora/config.h.example
Co-Authored-By: lociii <github@jensnistler.de>
Update flora/flora.ino
Co-Authored-By: lociii <github@jensnistler.de>
@sidddy

sidddy approved these changes Nov 16, 2018

@sidddy sidddy merged commit 807ce24 into sidddy:master Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment