Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable version controlling for SiddhiProcess CR objects #57

Merged
merged 4 commits into from Jul 22, 2019

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

Resolve #42

Goals

Previously SiddhiProcesses were unable to support version control. Here we enable version controlling in SiddhiProcess level.

Approach

Previously we have used the Client.Create() function in the controller-runtime client. Here we replace that function with controllerutil.CreateOrUpdate() function. The new function creates a k8s object if it isn't available. Otherwise, it gracefully updates the k8s object according to the mutate function that embedded to each k8s creation.

Automation tests

  • Unit tests

    Update the unit tests

Test environment

minikube version: v1.2.0

Learning

From this change users can also change a stateful app to stateless and vice versa without any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning in siddhi application level
2 participants